From 589bf35cd17aa5a5d91c4ca7ca3c99192ecd5cbb Mon Sep 17 00:00:00 2001 From: David Vacca Date: Fri, 26 Sep 2025 14:07:25 -0700 Subject: [PATCH] Delete ReactVirtualTextViewManager from codebase (#53945) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/53945 ReactVirtualTextViewManager is an internal legacy architecture class that's unused, we are deleting it changelog: [internal] internal Reviewed By: alanleedev Differential Revision: D83186611 fbshipit-source-id: 323c77077ab91ffec35af8e4c12da4bdf13fa233 --- .../facebook/react/shell/MainReactPackage.kt | 5 -- .../views/text/ReactVirtualTextViewManager.kt | 54 ------------------- 2 files changed, 59 deletions(-) delete mode 100644 packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactVirtualTextViewManager.kt diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/shell/MainReactPackage.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/shell/MainReactPackage.kt index c122c2f20e7..ce74cab1d22 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/shell/MainReactPackage.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/shell/MainReactPackage.kt @@ -152,7 +152,6 @@ constructor(private val config: MainPackageConfig? = null) : if (ReactNativeFeatureFlags.enablePreparedTextLayout()) PreparedLayoutTextViewManager() else ReactTextViewManager(), ReactViewManager(), - com.facebook.react.views.text.ReactVirtualTextViewManager(), ReactUnimplementedViewManager(), ) @@ -195,10 +194,6 @@ constructor(private val config: MainPackageConfig? = null) : else ReactTextViewManager() }, ReactViewManager.REACT_CLASS to ModuleSpec.viewManagerSpec { ReactViewManager() }, - com.facebook.react.views.text.ReactVirtualTextViewManager.REACT_CLASS to - ModuleSpec.viewManagerSpec { - com.facebook.react.views.text.ReactVirtualTextViewManager() - }, ReactUnimplementedViewManager.REACT_CLASS to ModuleSpec.viewManagerSpec { ReactUnimplementedViewManager() }, ) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactVirtualTextViewManager.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactVirtualTextViewManager.kt deleted file mode 100644 index 225d12a6576..00000000000 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactVirtualTextViewManager.kt +++ /dev/null @@ -1,54 +0,0 @@ -/* - * Copyright (c) Meta Platforms, Inc. and affiliates. - * - * This source code is licensed under the MIT license found in the - * LICENSE file in the root directory of this source tree. - */ - -package com.facebook.react.views.text - -import android.view.View -import com.facebook.react.common.annotations.internal.LegacyArchitecture -import com.facebook.react.common.annotations.internal.LegacyArchitectureLogLevel -import com.facebook.react.common.annotations.internal.LegacyArchitectureLogger -import com.facebook.react.module.annotations.ReactModule -import com.facebook.react.uimanager.BaseViewManager -import com.facebook.react.uimanager.ThemedReactContext - -/** - * Manages raw text nodes. Since they are used only as a virtual nodes any type of native view - * operation will throw an [IllegalStateException] - */ -@Suppress("DEPRECATION") -@ReactModule(name = ReactVirtualTextViewManager.REACT_CLASS) -@LegacyArchitecture(logLevel = LegacyArchitectureLogLevel.ERROR) -@Deprecated( - message = "This class is part of Legacy Architecture and will be removed in a future release", - level = DeprecationLevel.WARNING, -) -internal class ReactVirtualTextViewManager : BaseViewManager() { - - override fun getName(): String = REACT_CLASS - - override fun createViewInstance(context: ThemedReactContext): View { - throw IllegalStateException("Attempt to create a native view for RCTVirtualText") - } - - override fun updateExtraData(view: View, extraData: Any): Unit = Unit - - override fun getShadowNodeClass(): Class = - ReactVirtualTextShadowNode::class.java - - override fun createShadowNodeInstance(): ReactVirtualTextShadowNode = ReactVirtualTextShadowNode() - - internal companion object { - const val REACT_CLASS: String = "RCTVirtualText" - - init { - LegacyArchitectureLogger.assertLegacyArchitecture( - "ReactVirtualTextViewManager", - LegacyArchitectureLogLevel.ERROR, - ) - } - } -}