BREAKING: Pass parameters to transformer.transform as object

Reviewed By: jeanlauliac

Differential Revision: D5037155

fbshipit-source-id: fbd18bd62254d7e1522f659ea62055e66748a951
This commit is contained in:
David Aurelio
2017-05-11 08:35:07 -07:00
committed by Facebook Github Bot
parent 70b7488f97
commit 58337c9032
7 changed files with 50 additions and 33 deletions
@@ -95,10 +95,16 @@ describe('transforming JS modules:', () => {
const variants = {dev: {dev: true}, prod: {dev: false}};
transformModule(sourceCode, options(variants), () => {
expect(transformer.transform)
.toBeCalledWith(sourceCode, filename, {...defaults, ...variants.dev});
expect(transformer.transform)
.toBeCalledWith(sourceCode, filename, {...defaults, ...variants.prod});
expect(transformer.transform).toBeCalledWith({
filename,
options: {...defaults, ...variants.dev},
src: sourceCode,
});
expect(transformer.transform).toBeCalledWith({
filename,
options: {...defaults, ...variants.prod},
src: sourceCode,
});
done();
});
},
@@ -70,11 +70,11 @@ function transformModule(
const {filename, transformer, variants = defaultVariants} = options;
const tasks = {};
Object.keys(variants).forEach(name => {
tasks[name] = asyncify(() => transformer.transform(
code,
tasks[name] = asyncify(() => transformer.transform({
filename,
{...defaultTransformOptions, ...variants[name]},
)
options: {...defaultTransformOptions, ...variants[name]},
src: code,
})
);
});