From 5751035f648879c6ed84293270ffc4902ee64d6e Mon Sep 17 00:00:00 2001 From: Aditya Sharat Date: Fri, 7 Jun 2019 09:22:17 -0700 Subject: [PATCH] Adds check to unset a YogaNode's parent during reconciliation. Summary: Adds check to unset a YogaNode's parent during reconciliation. Reviewed By: davidaurelio Differential Revision: D15714899 fbshipit-source-id: 6e2c2a28106574d062fec722c9a051acea87d0b6 --- ReactAndroid/src/main/java/com/facebook/yoga/YogaNode.java | 2 ++ .../src/main/java/com/facebook/yoga/YogaNodeJNIBase.java | 5 +++++ 2 files changed, 7 insertions(+) diff --git a/ReactAndroid/src/main/java/com/facebook/yoga/YogaNode.java b/ReactAndroid/src/main/java/com/facebook/yoga/YogaNode.java index a01a0bdde49..9a8e19663fd 100644 --- a/ReactAndroid/src/main/java/com/facebook/yoga/YogaNode.java +++ b/ReactAndroid/src/main/java/com/facebook/yoga/YogaNode.java @@ -42,6 +42,8 @@ public abstract class YogaNode { @Nullable public abstract YogaNode getOwner(); + public abstract void unsetOwner(); + /** @deprecated Use #getOwner() instead. This will be removed in the next version. */ @Deprecated @Nullable diff --git a/ReactAndroid/src/main/java/com/facebook/yoga/YogaNodeJNIBase.java b/ReactAndroid/src/main/java/com/facebook/yoga/YogaNodeJNIBase.java index c48162f4a47..0e1f68c8e97 100644 --- a/ReactAndroid/src/main/java/com/facebook/yoga/YogaNodeJNIBase.java +++ b/ReactAndroid/src/main/java/com/facebook/yoga/YogaNodeJNIBase.java @@ -137,6 +137,11 @@ public abstract class YogaNodeJNIBase extends YogaNode implements Cloneable { return mOwner; } + @Override + public void unsetOwner() { + mOwner = null; + } + /** @deprecated Use #getOwner() instead. This will be removed in the next version. */ @Deprecated @Nullable