mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
fix: Crash if WebView is disabled (#34483)
Summary: When the webview is updated by play store, all apps that has loaded webview gets killed. For background see https://issuetracker.google.com/issues/228611949?pli=1 We have a long-running app and don't want this to happen and while we are not using webview anywhere, we are using websockets that loads it for reading cookies, however we are not using cookies to authenticate the websocket and thus want to disable the webview to avoid loading it unnecessarily and then getting killed unnecessarily. The webview has support for beeing disabled https://developer.android.com/reference/android/webkit/WebView#disableWebView() however as-is this crashes React Native. It seems to me like this case is very similar to not having web view installed and should be handled in the same way. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Android] [Fixed] - Avoid crash in ForwardingCookieHandler if webview is disabled Pull Request resolved: https://github.com/facebook/react-native/pull/34483 Test Plan: Add `WebView.disableWebView();` as the first line in `MainActivity.onCreate`. Reviewed By: christophpurrer Differential Revision: D38981827 Pulled By: cipolleschi fbshipit-source-id: 335a8420568ad0c80b834ae8a3b164e55ebe26f3
This commit is contained in:
committed by
Facebook GitHub Bot
parent
4f486c7e4e
commit
5451cd48bd
+3
-1
@@ -152,7 +152,9 @@ public class ForwardingCookieHandler extends CookieHandler {
|
||||
|| (message != null
|
||||
&& (message.contains("WebView provider")
|
||||
|| message.contains("No WebView installed")
|
||||
|| message.contains("Cannot load WebView")))) {
|
||||
|| message.contains("Cannot load WebView")
|
||||
|| message.contains("disableWebView")
|
||||
|| message.contains("WebView is disabled")))) {
|
||||
return null;
|
||||
} else {
|
||||
throw exception;
|
||||
|
||||
Reference in New Issue
Block a user