From 53a0470b83416d3eb07931df00385de071f231a4 Mon Sep 17 00:00:00 2001 From: Kevin Gozali Date: Sun, 18 Mar 2018 23:49:52 -0700 Subject: [PATCH] iOS JSC: Use ICxxExceptionManager to report exception Reviewed By: shergin Differential Revision: D7224945 fbshipit-source-id: 8aadbc04c700d6e965be311085d95332571b00b0 --- React/Fabric/RCTFabricUIManagerWrapper.h | 2 ++ React/Fabric/RCTFabricUIManagerWrapper.mm | 10 ++++++++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/React/Fabric/RCTFabricUIManagerWrapper.h b/React/Fabric/RCTFabricUIManagerWrapper.h index d40ef78c359..234668bb1b0 100644 --- a/React/Fabric/RCTFabricUIManagerWrapper.h +++ b/React/Fabric/RCTFabricUIManagerWrapper.h @@ -17,6 +17,7 @@ namespace facebook { namespace react { class FabricUIManager; +class ExceptionManager; } // namespace react } // namespace facebook @@ -29,6 +30,7 @@ using namespace facebook::react; @interface RCTFabricUIManagerWrapper : NSObject - (std::shared_ptr)manager; +- (std::shared_ptr)exceptionManager; @end diff --git a/React/Fabric/RCTFabricUIManagerWrapper.mm b/React/Fabric/RCTFabricUIManagerWrapper.mm index 811aa8d0ad8..d3b6839eba0 100644 --- a/React/Fabric/RCTFabricUIManagerWrapper.mm +++ b/React/Fabric/RCTFabricUIManagerWrapper.mm @@ -7,18 +7,18 @@ #import "RCTFabricUIManagerWrapper.h" +#include #include - #include #include - #import "RCTFabricPlatformUIOperationManager.h" // This file contains experimental placeholders, nothing is finalized. @implementation RCTFabricUIManagerWrapper { std::shared_ptr _manager; + std::shared_ptr _exceptionManager; std::shared_ptr _platformUIOperationManager; } @@ -26,6 +26,7 @@ { self = [super init]; if (self) { + _exceptionManager = std::make_shared(); _platformUIOperationManager = std::make_shared(); _manager = std::make_shared(_platformUIOperationManager); } @@ -37,6 +38,11 @@ return _manager; } +- (std::shared_ptr)exceptionManager +{ + return _exceptionManager; +} + - (void)invalidate { }