mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Make Lambda function called in NativeModule mutable to improve performance (#28297)
Summary: Fixes https://github.com/facebook/react-native/issues/28271 As explained by mmallet-youilabs , if the parameters passed to the `move` function are too expensive, this can have an impact on performance. Thus making these parameters captured by value mutable, the parameters are not movable. ## Changelog [iOS] [Fixed] - Message Pull Request resolved: https://github.com/facebook/react-native/pull/28297 Test Plan: Steps to reproduce (and expected results) are not applicable (unless running with a profiler). Differential Revision: D20464278 Pulled By: shergin fbshipit-source-id: 846a8bc6c61cb4aa21fbd96b419c3775190a2c84
This commit is contained in:
committed by
Facebook GitHub Bot
parent
bcf2a716fb
commit
5290047d09
@@ -148,7 +148,7 @@ void CxxNativeModule::invoke(
|
||||
// mhorowitz #7128529: convert C++ exceptions to Java
|
||||
|
||||
messageQueueThread_->runOnQueue(
|
||||
[method, params = std::move(params), first, second, callId]() {
|
||||
[method, params = std::move(params), first, second, callId]() mutable {
|
||||
#ifdef WITH_FBSYSTRACE
|
||||
if (callId != -1) {
|
||||
fbsystrace_end_async_flow(TRACE_TAG_REACT_APPS, "native", callId);
|
||||
|
||||
Reference in New Issue
Block a user