From 5217890df9f42feab68587d3d9edfc62ef787a20 Mon Sep 17 00:00:00 2001 From: Riccardo Cipolleschi Date: Thu, 12 Oct 2023 03:18:50 -0700 Subject: [PATCH] Back out "Make sure template is consuming the right buildToolsVersion" (#40854) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/40854 This [commit](https://github.com/facebook/react-native/commit/a5d5ead1a474832a911c3a6e44b6d6450bca3fd6) seems to break all the Android template tests: [CircleCI](https://app.circleci.com/pipelines/github/facebook/react-native/34139/workflows/b203bbea-d3c4-45aa-9ce1-1ddde6d88bc0). ## Changelog: [Android][Changed] - revert commit https://github.com/facebook/react-native/commit/a5d5ead1a474832a911c3a6e44b6d6450bca3fd6 ## Facebook: Original Phabricator Diff: D50019777 Reviewed By: sammy-SC Differential Revision: D50217952 fbshipit-source-id: d9b93ad72f08cf9f04cacfc04ea9b418f8129079 --- .circleci/configurations/top_level.yml | 2 +- packages/react-native/template/android/app/build.gradle | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.circleci/configurations/top_level.yml b/.circleci/configurations/top_level.yml index 22fb66b3fc4..4d44e1eae97 100644 --- a/.circleci/configurations/top_level.yml +++ b/.circleci/configurations/top_level.yml @@ -25,7 +25,7 @@ references: android-defaults: &android-defaults working_directory: ~/react-native docker: - - image: reactnativecommunity/react-native-android:v12.0 + - image: reactnativecommunity/react-native-android:v11.0 environment: - TERM: "dumb" - GRADLE_OPTS: '-Dorg.gradle.daemon=false' diff --git a/packages/react-native/template/android/app/build.gradle b/packages/react-native/template/android/app/build.gradle index 86512f88a4a..94222a1e807 100644 --- a/packages/react-native/template/android/app/build.gradle +++ b/packages/react-native/template/android/app/build.gradle @@ -71,7 +71,7 @@ def jscFlavor = 'org.webkit:android-jsc:+' android { ndkVersion rootProject.ext.ndkVersion - buildToolsVersion rootProject.ext.buildToolsVersion + compileSdk rootProject.ext.compileSdkVersion namespace "com.helloworld"