From 516642c1016ccf6d3c5053be8d5c232e15797f42 Mon Sep 17 00:00:00 2001 From: Nick Gerleman Date: Fri, 21 Apr 2023 09:58:07 -0700 Subject: [PATCH] Remove YGTraversePreOrder (#37014) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/37014 X-link: https://github.com/facebook/yoga/pull/1253 This is unused, and kinda missed the intent of Yoga.h and YG* functions being a C ABI. Reviewed By: rshest Differential Revision: D45138646 fbshipit-source-id: 743e7d0f43c122932c3a6f43ce564c0f209b4771 --- .../ReactCommon/yoga/yoga/Yoga.cpp | 19 ------------------- .../react-native/ReactCommon/yoga/yoga/Yoga.h | 6 ------ 2 files changed, 25 deletions(-) diff --git a/packages/react-native/ReactCommon/yoga/yoga/Yoga.cpp b/packages/react-native/ReactCommon/yoga/yoga/Yoga.cpp index 915de666ef9..78486e2e957 100644 --- a/packages/react-native/ReactCommon/yoga/yoga/Yoga.cpp +++ b/packages/react-native/ReactCommon/yoga/yoga/Yoga.cpp @@ -4347,22 +4347,3 @@ YOGA_EXPORT void YGConfigSetCloneNodeFunc( const YGCloneNodeFunc callback) { config->setCloneNodeCallback(callback); } - -static void YGTraverseChildrenPreOrder( - const YGVector& children, - const std::function& f) { - for (YGNodeRef node : children) { - f(node); - YGTraverseChildrenPreOrder(node->getChildren(), f); - } -} - -void YGTraversePreOrder( - YGNodeRef const node, - std::function&& f) { - if (!node) { - return; - } - f(node); - YGTraverseChildrenPreOrder(node->getChildren(), f); -} diff --git a/packages/react-native/ReactCommon/yoga/yoga/Yoga.h b/packages/react-native/ReactCommon/yoga/yoga/Yoga.h index 501506d503c..7b579687005 100644 --- a/packages/react-native/ReactCommon/yoga/yoga/Yoga.h +++ b/packages/react-native/ReactCommon/yoga/yoga/Yoga.h @@ -367,14 +367,8 @@ YG_EXTERN_C_END #ifdef __cplusplus -#include #include -// Calls f on each node in the tree including the given node argument. -void YGTraversePreOrder( - YGNodeRef node, - std::function&& f); - void YGNodeSetChildren(YGNodeRef owner, const std::vector& children); #endif