Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Stop hard-coding ReactModuleInfo constructor args

Browse Source 
Summary:
We're going to migrate our NativeModules to the TurboModule system soon. Therefore, it's no longer safe to assume that all NativeModules are not TurboModules. Also, it's not a good idea to hard-code this stuff if we can calculate the correct values on the fly.

Changelog:
[Internal]

Reviewed By: PeteTheHeat

Differential Revision: D18980859

fbshipit-source-id: 399a75a72d7f57998b217502ff79d7d911cc5a1c
This commit is contained in:
Ramanpreet Nara
2019-12-13 16:08:58 -08:00
committed by Facebook Github Bot
parent aff6bad27c
commit 50999b1cf2
3 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/CoreModulesPackage.java
+2 -1
View File
@@ -30,6 +30,7 @@ import com.facebook.react.modules.debug.DevSettingsModule;
import com.facebook.react.modules.debug.SourceCodeModule;
import com.facebook.react.modules.deviceinfo.DeviceInfoModule;
import com.facebook.react.modules.systeminfo.AndroidInfoModule;
import com.facebook.react.turbomodule.core.interfaces.TurboModule;
import com.facebook.react.uimanager.UIImplementationProvider;
import com.facebook.react.uimanager.UIManagerModule;
import com.facebook.react.uimanager.ViewManager;
@@ -116,7 +117,7 @@ import java.util.Map;
reactModule.needsEagerInit(),
reactModule.hasConstants(),
reactModule.isCxxModule(),
false));
TurboModule.class.isAssignableFrom(moduleClass)));
}
return new ReactModuleInfoProvider() {
ReactAndroid/src/main/java/com/facebook/react/shell/BUCK
+1
View File
@@ -49,6 +49,7 @@ rn_android_library(
react_native_target("java/com/facebook/react/modules/toast:toast"),
react_native_target("java/com/facebook/react/modules/vibration:vibration"),
react_native_target("java/com/facebook/react/modules/websocket:websocket"),
react_native_target("java/com/facebook/react/turbomodule/core/interfaces:interfaces"),
react_native_target("java/com/facebook/react/uimanager:uimanager"),
react_native_target("java/com/facebook/react/views/art:art"),
react_native_target("java/com/facebook/react/views/checkbox:checkbox"),
ReactAndroid/src/main/java/com/facebook/react/shell/MainReactPackage.java
+2 -1
View File
@@ -41,6 +41,7 @@ import com.facebook.react.modules.timepicker.TimePickerDialogModule;
import com.facebook.react.modules.toast.ToastModule;
import com.facebook.react.modules.vibration.VibrationModule;
import com.facebook.react.modules.websocket.WebSocketModule;
import com.facebook.react.turbomodule.core.interfaces.TurboModule;
import com.facebook.react.uimanager.ViewManager;
import com.facebook.react.views.art.ARTRenderableViewManager;
import com.facebook.react.views.art.ARTSurfaceViewManager;
@@ -255,7 +256,7 @@ public class MainReactPackage extends TurboReactPackage {
reactModule.needsEagerInit(),
reactModule.hasConstants(),
reactModule.isCxxModule(),
false));
TurboModule.class.isAssignableFrom(moduleClass)));
}
return new ReactModuleInfoProvider() {