From 506e3a208e2fd420fa244fc5327790fcfd9718ff Mon Sep 17 00:00:00 2001 From: Emily Janzer Date: Thu, 27 Feb 2020 12:14:58 -0800 Subject: [PATCH] Create AsyncDevSupportManager + associated classes Summary: This is the second step in creating a new DevSupportManager impl with more async-friendly APIs for bundle loading, which I'll use in bridgeless mode. This diff creates a new interface, AsyncDevSupportManager, and two implementations, mirroring what we currently have. This new interface doesn't define any methods yet. Changelog: [Android][Changed] Specify DevSupportManager.setPackagerLocationCustomizer in DevSupportManager impls Reviewed By: mdvacca Differential Revision: D19870812 fbshipit-source-id: 042a43e1a3055aba6d7325f948060300b5bf17f3 --- .../com/facebook/react/devsupport/DevSupportManagerBase.java | 3 ++- .../facebook/react/devsupport/DisabledDevSupportManager.java | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerBase.java b/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerBase.java index 3da833ab4f8..99e181b330f 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerBase.java +++ b/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerBase.java @@ -1227,7 +1227,8 @@ public abstract class DevSupportManagerBase } @Override - public void setPackagerLocationCustomizer(PackagerLocationCustomizer packagerLocationCustomizer) { + public void setPackagerLocationCustomizer( + DevSupportManager.PackagerLocationCustomizer packagerLocationCustomizer) { mPackagerLocationCustomizer = packagerLocationCustomizer; } } diff --git a/ReactAndroid/src/main/java/com/facebook/react/devsupport/DisabledDevSupportManager.java b/ReactAndroid/src/main/java/com/facebook/react/devsupport/DisabledDevSupportManager.java index 2001f11ff45..df0ca843ba2 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/devsupport/DisabledDevSupportManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/devsupport/DisabledDevSupportManager.java @@ -153,7 +153,7 @@ public class DisabledDevSupportManager implements DevSupportManager { @Override public void setPackagerLocationCustomizer( - PackagerLocationCustomizer packagerLocationCustomizer) {} + DevSupportManager.PackagerLocationCustomizer packagerLocationCustomizer) {} @Override public void handleException(Exception e) {