From 505f9fc74929326ea246eb4aeb700f97820c702f Mon Sep 17 00:00:00 2001 From: David Vacca Date: Fri, 22 Jan 2021 18:41:59 -0800 Subject: [PATCH] Add logging to analyze Bug in BottomSheetRootViewGroup Summary: This diff adds logs and soft errors to analyze task T83470429 changelog: [internal] internal Reviewed By: JoshuaGross Differential Revision: D26032513 fbshipit-source-id: e6ee3f8a6ac942e794439396e1a9f7d6157d20a5 --- .../facebook/react/uimanager/UIManagerHelper.java | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerHelper.java b/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerHelper.java index 2ad3f029264..ccd5600f268 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerHelper.java +++ b/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerHelper.java @@ -93,7 +93,13 @@ public class UIManagerHelper { */ @Nullable public static EventDispatcher getEventDispatcherForReactTag(ReactContext context, int reactTag) { - return getEventDispatcher(context, getUIManagerType(reactTag)); + EventDispatcher eventDispatcher = getEventDispatcher(context, getUIManagerType(reactTag)); + if (eventDispatcher == null) { + ReactSoftException.logSoftException( + "UIManagerHelper", + new IllegalStateException("Cannot get EventDispatcher for reactTag " + reactTag)); + } + return eventDispatcher; } /** @@ -112,6 +118,10 @@ public class UIManagerHelper { } UIManager uiManager = getUIManager(context, uiManagerType, false); if (uiManager == null) { + ReactSoftException.logSoftException( + "UIManagerHelper", + new ReactNoCrashSoftException( + "Unable to find UIManager for UIManagerType " + uiManagerType)); return null; } EventDispatcher eventDispatcher = (EventDispatcher) uiManager.getEventDispatcher();