From 4fcfde1114374692b89b51c27b4e3c11cb1a13bb Mon Sep 17 00:00:00 2001 From: Alex Hunt Date: Wed, 13 Dec 2023 03:37:32 -0800 Subject: [PATCH] Omit synthetic Debugger.disable message in modern CDP backend (#41912) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/41912 Progress towards an opt-in setup for our new CDP backend. - For `DevSupportManagerBase` on Android: Conditionally omit sending `Debugger.disable` CDP message when new CDP backend is enabled. Reviewed By: motiz88 Differential Revision: D52040149 fbshipit-source-id: 452f46395261d2d9670bd38192d06e6fa8e1f93f --- .../facebook/react/devsupport/DevSupportManagerBase.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerBase.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerBase.java index b9ab16eb9f9..0bf65cdaf43 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerBase.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerBase.java @@ -33,6 +33,7 @@ import com.facebook.common.logging.FLog; import com.facebook.infer.annotation.Assertions; import com.facebook.react.R; import com.facebook.react.bridge.DefaultJSExceptionHandler; +import com.facebook.react.bridge.InspectorFlags; import com.facebook.react.bridge.JSBundleLoader; import com.facebook.react.bridge.ReactContext; import com.facebook.react.bridge.ReactMarker; @@ -1043,8 +1044,10 @@ public abstract class DevSupportManagerBase implements DevSupportManager { @Override public void onPackagerReloadCommand() { - // Disable debugger to resume the JsVM & avoid thread locks while reloading - mDevServerHelper.disableDebugger(); + if (!InspectorFlags.getEnableModernCDPRegistry()) { + // Disable debugger to resume the JsVM & avoid thread locks while reloading + mDevServerHelper.disableDebugger(); + } UiThreadUtil.runOnUiThread(() -> handleReloadJS()); }