Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Back out "Fix - ReconnectingWebSocket race condition mClosed"

Browse Source 
Summary:
Changelog:[Internal]
Original commit changeset: 48793bd3bea9

Reviewed By: ShikaSD

Differential Revision: D31170947

fbshipit-source-id: cb460e3261fdc2a0df6e3a4597c61bd879ecf38f
This commit is contained in:
Amy Nichol
2021-09-24 09:42:58 -07:00
committed by Facebook GitHub Bot
parent 9cf4bb73c0
commit 4e8da9b28f
1 changed files with 6 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/packagerconnection/ReconnectingWebSocket.java
+6 -12
View File
@@ -66,10 +66,8 @@ public final class ReconnectingWebSocket extends WebSocketListener {
}
public void connect() {
synchronized (this) {
if (mClosed) {
throw new IllegalStateException("Can't connect closed client");
}
if (mClosed) {
throw new IllegalStateException("Can't connect closed client");
}
Request request = new Request.Builder().url(mUrl).build();
@@ -84,10 +82,8 @@ public final class ReconnectingWebSocket extends WebSocketListener {
}
private void reconnect() {
synchronized (this) {
if (mClosed) {
throw new IllegalStateException("Can't reconnect closed client");
}
if (mClosed) {
throw new IllegalStateException("Can't reconnect closed client");
}
if (!mSuppressConnectionErrors) {
@@ -106,10 +102,8 @@ public final class ReconnectingWebSocket extends WebSocketListener {
}
public void closeQuietly() {
synchronized (this) {
mClosed = true;
closeWebSocketQuietly();
}
mClosed = true;
closeWebSocketQuietly();
mMessageCallback = null;
if (mConnectionCallback != null) {