From 4d22d02b772b684eab465bd63367104dbcbea28d Mon Sep 17 00:00:00 2001 From: Moti Zilberman Date: Wed, 10 Jan 2024 06:48:03 -0800 Subject: [PATCH] C++ InspectorPackagerConnection: Indicate new implementation in `/json` response (#42200) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/42200 Changelog: [Internal] Quick hack to make it easy to determine whether a given build of React Native is using the C++ implementation of InspectorPackagerConnection or the legacy platform-specific implementation. For now, we just append this information to the `title` field. Ultimately, rather than polluting the title, this should be an inert capability flag that gets reported via `inspector-proxy`. I'm not doing that yet since we have work in the pipeline to set up a proper capability flag system soon. Reviewed By: huntie Differential Revision: D52629415 fbshipit-source-id: a4e873f4be78ae49b35b94fd5d41d0e2efc02dbe --- .../jsinspector-modern/InspectorPackagerConnection.cpp | 2 +- .../tests/InspectorPackagerConnectionTest.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react-native/ReactCommon/jsinspector-modern/InspectorPackagerConnection.cpp b/packages/react-native/ReactCommon/jsinspector-modern/InspectorPackagerConnection.cpp index 7aa01dd97e3..829c633f09f 100644 --- a/packages/react-native/ReactCommon/jsinspector-modern/InspectorPackagerConnection.cpp +++ b/packages/react-native/ReactCommon/jsinspector-modern/InspectorPackagerConnection.cpp @@ -142,7 +142,7 @@ folly::dynamic InspectorPackagerConnection::Impl::pages() { for (const auto& page : pages) { array.push_back(folly::dynamic::object("id", std::to_string(page.id))( - "title", page.title)("app", app_)("vm", page.vm)); + "title", page.title + " [C++ connection]")("app", app_)("vm", page.vm)); } return array; } diff --git a/packages/react-native/ReactCommon/jsinspector-modern/tests/InspectorPackagerConnectionTest.cpp b/packages/react-native/ReactCommon/jsinspector-modern/tests/InspectorPackagerConnectionTest.cpp index 7dd0ebccf15..5ed3edab6ad 100644 --- a/packages/react-native/ReactCommon/jsinspector-modern/tests/InspectorPackagerConnectionTest.cpp +++ b/packages/react-native/ReactCommon/jsinspector-modern/tests/InspectorPackagerConnectionTest.cpp @@ -170,7 +170,7 @@ TEST_F(InspectorPackagerConnectionTest, TestGetPages) { "/payload", ElementsAreArray({AllOf( AtJsonPtr("/app", Eq("my-app")), - AtJsonPtr("/title", Eq("mock-title")), + AtJsonPtr("/title", Eq("mock-title [C++ connection]")), AtJsonPtr("/vm", Eq("mock-vm")), AtJsonPtr("/id", Eq(std::to_string(pageId))))})))))) .RetiresOnSaturation();