From 4ba9d0ecb15b38b81347a20aa5cc8403381f633f Mon Sep 17 00:00:00 2001
From: Nicola Corti <ncor@fb.com>
Date: Thu, 15 Sep 2022 07:00:43 -0700
Subject: [PATCH] Make the Android unitTests compile (#34690)

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/34690

While working on another part of the codebase I realized that
our Unit Tests are not compiling due to references to missing classes.
I'm cleaning them up + hooking the compileTest task inside the
`buildAll` task so at least they will be compiled on both CIs.

Changelog:
[Internal] [Changed] - Make the Android unitTests compile

Reviewed By: cipolleschi

Differential Revision: D39501945

fbshipit-source-id: 03d3e4872d6c738b8b85d1fef9302ac230e857d2
---
 .../react/uimanager/UIManagerModuleTest.java  | 44 -------------------
 build.gradle.kts                              |  3 ++
 2 files changed, 3 insertions(+), 44 deletions(-)

diff --git a/ReactAndroid/src/test/java/com/facebook/react/uimanager/UIManagerModuleTest.java b/ReactAndroid/src/test/java/com/facebook/react/uimanager/UIManagerModuleTest.java
index 2a788197591..2aae5ed152d 100644
--- a/ReactAndroid/src/test/java/com/facebook/react/uimanager/UIManagerModuleTest.java
+++ b/ReactAndroid/src/test/java/com/facebook/react/uimanager/UIManagerModuleTest.java
@@ -11,9 +11,6 @@ import static org.assertj.core.api.Assertions.assertThat;
 import static org.mockito.Matchers.any;
 import static org.mockito.Mockito.doAnswer;
 import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.spy;
-import static org.mockito.Mockito.times;
-import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
 
 import android.graphics.Color;
@@ -21,10 +18,7 @@ import android.view.View;
 import android.view.ViewGroup;
 import android.widget.TextView;
 import com.facebook.react.ReactRootView;
-import com.facebook.react.animation.Animation;
-import com.facebook.react.animation.AnimationPropertyUpdater;
 import com.facebook.react.bridge.Arguments;
-import com.facebook.react.bridge.Callback;
 import com.facebook.react.bridge.CatalystInstance;
 import com.facebook.react.bridge.JavaOnlyArray;
 import com.facebook.react.bridge.JavaOnlyMap;
@@ -460,44 +454,6 @@ public class UIManagerModuleTest {
     assertThat(view0.getLeft()).isEqualTo(1);
   }
 
-  private static class AnimationStub extends Animation {
-
-    public AnimationStub(int animationID, AnimationPropertyUpdater propertyUpdater) {
-      super(animationID, propertyUpdater);
-    }
-
-    @Override
-    public void run() {}
-  }
-
-  @Test
-  public void testAddAndRemoveAnimation() {
-    UIManagerModule uiManagerModule = getUIManagerModule();
-    TestMoveDeleteHierarchy hierarchy = createMoveDeleteHierarchy(uiManagerModule);
-
-    AnimationPropertyUpdater mockPropertyUpdater = mock(AnimationPropertyUpdater.class);
-    Animation mockAnimation = spy(new AnimationStub(1000, mockPropertyUpdater));
-    Callback callbackMock = mock(Callback.class);
-
-    int rootTag = hierarchy.rootView;
-    uiManagerModule.createView(
-        hierarchy.rootView,
-        ReactViewManager.REACT_CLASS,
-        rootTag,
-        JavaOnlyMap.of("collapsable", false));
-
-    uiManagerModule.registerAnimation(mockAnimation);
-    uiManagerModule.addAnimation(hierarchy.rootView, 1000, callbackMock);
-    uiManagerModule.removeAnimation(hierarchy.rootView, 1000);
-
-    uiManagerModule.onBatchComplete();
-    executePendingFrameCallbacks();
-
-    verify(callbackMock, times(1)).invoke(false);
-    verify(mockAnimation).run();
-    verify(mockAnimation).cancel();
-  }
-
   /**
    * Makes sure replaceExistingNonRootView by replacing a view with a new view that has a background
    * color set.
diff --git a/build.gradle.kts b/build.gradle.kts
index d08c06c1003..4f5bf3708c3 100644
--- a/build.gradle.kts
+++ b/build.gradle.kts
@@ -59,6 +59,9 @@ tasks.register("buildAll") {
   dependsOn(":ReactAndroid:installArchives")
   // This builds RN Tester for Hermes/JSC for debug only
   dependsOn(":packages:rn-tester:android:app:assembleDebug")
+  // This compiles the Unit Test sources (without running them as they're partially broken)
+  dependsOn(":ReactAndroid:compileDebugUnitTestSources")
+  dependsOn(":ReactAndroid:compileReleaseUnitTestSources")
 }
 
 tasks.register("downloadAll") {