Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Log stack trace when unmountReactApplication is called in Fabric

Browse Source 
Summary:
Sometimes stopSurface crashes when unmountReactApplication is called under Fabric; knowing the stack trace up to this point might assist in debugging.

Changelog: [Internal]

Reviewed By: sammy-SC

Differential Revision: D24532027

fbshipit-source-id: f350e77fb1a2de52eb146b449f1d2f6e960fa017
This commit is contained in:
Joshua Gross
2020-10-26 12:30:35 -07:00
committed by Facebook GitHub Bot
parent 6f78e16c01
commit 4b58038515
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/ReactRootView.java
+5 -1
View File
@@ -490,7 +490,11 @@ public class ReactRootView extends FrameLayout implements RootView, ReactRoot {
UIManager uiManager =
UIManagerHelper.getUIManager(reactApplicationContext, getUIManagerType());
if (uiManager != null) {
FLog.e(TAG, "stopSurface for surfaceId: " + this.getId());
// TODO T48186892: remove when resolved
FLog.e(
TAG,
"stopSurface for surfaceId: " + this.getId(),
new RuntimeException("unmountReactApplication"));
if (getId() == NO_ID) {
ReactSoftException.logSoftException(
TAG,