From 496b0a8729b41266683fdd84de5618b23d06ce3d Mon Sep 17 00:00:00 2001 From: David Vacca Date: Tue, 5 Nov 2024 21:44:38 -0800 Subject: [PATCH] Migrate ReactVirtualTextShadowNode to kotlin and make it internal (#47434) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/47434 Migrate ReactVirtualTextShadowNode to kotlin and make it internal changelog: [Android][Breaking] Reduce visibility of ReactVirtualTextShadowNode to internal Reviewed By: shwanton Differential Revision: D65493927 fbshipit-source-id: 2b5997d000b5dc489ba93edb226455ef0855b98b --- .../react-native/ReactAndroid/api/ReactAndroid.api | 5 ----- ...tShadowNode.java => ReactVirtualTextShadowNode.kt} | 11 +++-------- 2 files changed, 3 insertions(+), 13 deletions(-) rename packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/{ReactVirtualTextShadowNode.java => ReactVirtualTextShadowNode.kt} (50%) diff --git a/packages/react-native/ReactAndroid/api/ReactAndroid.api b/packages/react-native/ReactAndroid/api/ReactAndroid.api index 9d39acc376c..b6c706efaf9 100644 --- a/packages/react-native/ReactAndroid/api/ReactAndroid.api +++ b/packages/react-native/ReactAndroid/api/ReactAndroid.api @@ -7522,11 +7522,6 @@ public class com/facebook/react/views/text/ReactTypefaceUtils { public static fun parseFontWeight (Ljava/lang/String;)I } -public class com/facebook/react/views/text/ReactVirtualTextShadowNode : com/facebook/react/views/text/ReactBaseTextShadowNode { - public fun ()V - public fun isVirtual ()Z -} - public class com/facebook/react/views/text/TextAttributeProps { public static final field TA_KEY_ACCESSIBILITY_ROLE S public static final field TA_KEY_ALIGNMENT S diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactVirtualTextShadowNode.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactVirtualTextShadowNode.kt similarity index 50% rename from packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactVirtualTextShadowNode.java rename to packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactVirtualTextShadowNode.kt index 3c6949a3081..bb98579ccf8 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactVirtualTextShadowNode.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactVirtualTextShadowNode.kt @@ -5,15 +5,10 @@ * LICENSE file in the root directory of this source tree. */ -package com.facebook.react.views.text; +package com.facebook.react.views.text /** A virtual text node. */ -public class ReactVirtualTextShadowNode extends ReactBaseTextShadowNode { +internal class ReactVirtualTextShadowNode : ReactBaseTextShadowNode() { - @Override - public boolean isVirtual() { - return true; - } - - public ReactVirtualTextShadowNode() {} + override fun isVirtual(): Boolean = true }