From 48ba8df8f24296866f85dec802d4b14088116a59 Mon Sep 17 00:00:00 2001 From: Jason Safaiyeh Date: Wed, 21 Jul 2021 13:24:31 -0700 Subject: [PATCH] Resolve some XCode warnings (#31883) Summary: UIAccessibilityVoiceOverStatusChanged deprecated (iOS 11+) in favor for UIAccessibilityVoiceOverStatusDidChangeNotification ref: https://developer.apple.com/documentation/uikit/uiaccessibilityvoiceoverstatuschanged?language=objc topLayoutGuide/bottomLayoutGuide deprecated (iOS 11+) in favor for safeAreaLayoutGuide ref: https://developer.apple.com/documentation/uikit/uiviewcontroller/1621367-toplayoutguide This block declaration is not a prototype warnings fixed by adding void to specify no parameters ref: https://stackoverflow.com/questions/47916585/objective-c-block-parameter-issue-this-block-declaration-is-not-a-prototype ## Changelog [Internal] [Fixed] - Resolved some deprecations Pull Request resolved: https://github.com/facebook/react-native/pull/31883 Test Plan: Tests should pass, no functionality should change. Reviewed By: fkgozali Differential Revision: D29822033 Pulled By: mdvacca fbshipit-source-id: dec8d612885634aca090ac3372cd4c7bf8a197ee --- React/Base/RCTBridgeModule.h | 2 +- React/CoreModules/RCTAccessibilityManager.mm | 2 +- React/Views/RCTView.m | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/React/Base/RCTBridgeModule.h b/React/Base/RCTBridgeModule.h index 31aaeffd2df..9ad1836ea8c 100644 --- a/React/Base/RCTBridgeModule.h +++ b/React/Base/RCTBridgeModule.h @@ -430,7 +430,7 @@ RCT_EXTERN_C_END @end typedef void (^RCTBridgelessBundleURLSetter)(NSURL *bundleURL); -typedef NSURL * (^RCTBridgelessBundleURLGetter)(); +typedef NSURL * (^RCTBridgelessBundleURLGetter)(void); /** * A class that allows NativeModules/TurboModules to read/write the bundleURL, with or without the bridge. diff --git a/React/CoreModules/RCTAccessibilityManager.mm b/React/CoreModules/RCTAccessibilityManager.mm index 3b15ec0e89a..1ea4436cf33 100644 --- a/React/CoreModules/RCTAccessibilityManager.mm +++ b/React/CoreModules/RCTAccessibilityManager.mm @@ -82,7 +82,7 @@ RCT_EXPORT_MODULE() [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(voiceVoiceOverStatusDidChange:) - name:UIAccessibilityVoiceOverStatusChanged + name:UIAccessibilityVoiceOverStatusDidChangeNotification object:nil]; self.contentSizeCategory = RCTSharedApplication().preferredContentSizeCategory; diff --git a/React/Views/RCTView.m b/React/Views/RCTView.m index 87ff206081f..c4b9a254387 100644 --- a/React/Views/RCTView.m +++ b/React/Views/RCTView.m @@ -490,7 +490,7 @@ RCT_NOT_IMPLEMENTED(-(instancetype)initWithCoder : unused) while (view) { UIViewController *controller = view.reactViewController; if (controller) { - return (UIEdgeInsets){controller.topLayoutGuide.length, 0, controller.bottomLayoutGuide.length, 0}; + return controller.view.safeAreaInsets; } view = view.superview; }