From 47f32ffae07905543bb83ca60c0f46400a8e5134 Mon Sep 17 00:00:00 2001 From: Vitali Zaidman Date: Thu, 4 Sep 2025 10:00:18 -0700 Subject: [PATCH] add comments regarding RCTPackagerConnection's reconnect (#53558) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/53558 Changelog: [Internal] Got confused regarding why "reconnect" does not actually trigger a reconnect. It turns out, it only triggers a reconnect if the URL has changed. Reviewed By: cipolleschi, huntie Differential Revision: D80629308 fbshipit-source-id: 098ef5e91f3748deb9bc707b79bc0395d2442ca4 --- packages/react-native/React/DevSupport/RCTPackagerConnection.h | 2 +- packages/react-native/React/DevSupport/RCTPackagerConnection.mm | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/react-native/React/DevSupport/RCTPackagerConnection.h b/packages/react-native/React/DevSupport/RCTPackagerConnection.h index 014f73f9793..cdd7c745a89 100644 --- a/packages/react-native/React/DevSupport/RCTPackagerConnection.h +++ b/packages/react-native/React/DevSupport/RCTPackagerConnection.h @@ -59,7 +59,7 @@ typedef void (^RCTConnectedHandler)(void); /** Disconnects and removes all handlers. */ - (void)stop; -/** Reconnect with given packager server. */ +/** Reconnect with given packager server, if packagerServerHostPort has changed. */ - (void)reconnect:(NSString *)packagerServerHostPort; /** diff --git a/packages/react-native/React/DevSupport/RCTPackagerConnection.mm b/packages/react-native/React/DevSupport/RCTPackagerConnection.mm index 39419d60e12..95dbf82437c 100644 --- a/packages/react-native/React/DevSupport/RCTPackagerConnection.mm +++ b/packages/react-native/React/DevSupport/RCTPackagerConnection.mm @@ -160,6 +160,7 @@ static RCTReconnectingWebSocket *socketForLocation(NSString *const serverHostPor - (void)bundleURLSettingsChanged { + // Will only reconnect if `packagerServerHostPort` has actually changed [self reconnect:[[RCTBundleURLProvider sharedSettings] packagerServerHostPort]]; }