Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

NativeAnimatedDriver: synchronize animation lifecycle closer to Fabric or Paper lifecycle

Browse Source 
Summary:
Switch between "Fabric" and "Non-Fabric" modes based on which types of native Views are being attached to animations. Don't allow non-Fabric to drive Fabric animations and vice-versa.

Changelog: [Internal]

Reviewed By: mdvacca

Differential Revision: D21985411

fbshipit-source-id: fb9bef1e38375b384430b4e0275e7b6d62eda7a4
This commit is contained in:
Joshua Gross
2020-06-11 20:46:48 -07:00
committed by Facebook GitHub Bot
parent 3346ac7f96
commit 472cf3f4ad
7 changed files with 447 additions and 118 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/animated/DivisionAnimatedNode.java
+2 -2
View File
@@ -42,12 +42,12 @@ import com.facebook.react.bridge.ReadableMap;
}
if (value == 0) {
throw new JSApplicationCausedNativeException(
"Detected a division by zero in " + "Animated.divide node");
"Detected a division by zero in Animated.divide node with Animated ID " + mTag);
}
mValue /= value;
} else {
throw new JSApplicationCausedNativeException(
"Illegal node ID set as an input for " + "Animated.divide node");
"Illegal node ID set as an input for Animated.divide node with Animated ID " + mTag);
}
}
}