From 457dd455524aba1bdb48ffd378fbe4fbac92fb01 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?H=C3=A9ctor=20Ramos?= <hramos@fb.com>
Date: Fri, 1 Apr 2022 02:41:04 -0700
Subject: [PATCH] Remove Hermes Compiler from react-native package (restore
 nightly jobs)

Summary:
Restore `nightly` jobs to green by removing `hermesc` from `react-native` package.

As a result, when building Hermes from source on developer's machines, the Hermes compiler will need to be built as well.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D35289425

fbshipit-source-id: 2a058f714d670fbb4d0486e7280cab7dd923fc63
---
 .circleci/config.yml | 31 +++++++++++++++++++------------
 1 file changed, 19 insertions(+), 12 deletions(-)

diff --git a/.circleci/config.yml b/.circleci/config.yml
index 1347042cdb8..5f05078e204 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -1023,12 +1023,16 @@ jobs:
             mkdir -p ~/.ssh
             echo '|1|If6MU203eXTaaWL678YEfWkVMrw=|kqLeIAyTy8pzpj8x8Ae4Fr8Mtlc= ssh-rsa AAAAB3NzaC1yc2EAAAABIwAAAQEAq2A7hRGmdnm9tUDbO9IDSwBK6TbQa+PXYPCPy6rbTrTtw7PHkccKrpp0yVhp5HdEIcKr6pLlVDBfOLX9QUsyCOV0wzfjIJNlGEYsdlLJizHhbn2mUjvSAHQqZETYP81eFzLQNnPHt4EVVUh7VfDESU84KezmD5QlWpXLmvU31/yMf+Se8xhHTvKSCZIFImWwoG6mbUoWf9nzpIoaSjB+weqqUUmpaaasXVal72J+UX2B+2RPW3RcT0eOzQgqlJL3RKrTJvdsjE3JEAvGq3lGHSZXy28G3skua2SmVi/w4yCE6gbODqnTWlg7+wC604ydGXA8VJiS5ap43JXiUFFAaQ==' >> ~/.ssh/known_hosts
       - checkout
-      - *attach_hermes_workspace
-      - run:
-          name: Move hermesc binaries to sdks/hermesc
-          command: |
-            mkdir -p ./sdks/hermesc
-            cp -R $HERMES_WS_DIR/hermesc/* ./sdks/hermesc
+      # TODO: (hramos) Filter out unnecessary files before adding Hermes Compiler to package
+      # - *attach_hermes_workspace
+      # - run:
+      #     name: Move hermesc binaries to sdks/hermesc
+      #     command: |
+      #       curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add -
+      #       apt update && apt install -y jq
+      #       mkdir -p ./sdks/hermesc
+      #       cp -R $HERMES_WS_DIR/hermesc/* ./sdks/hermesc
+
       - run_yarn
       - install_buck_tooling
       - download_buck_dependencies
@@ -1161,8 +1165,9 @@ workflows:
       - build_npm_package:
           # Build a release package on every untagged commit, but do not publish to npm.
           publish_npm_args: --dry-run
-          requires:
-            - store-hermesc
+          # TODO: (hramos) Slim down Hermes Compiler files before adding to react-native npm
+          # requires:
+          #   - store-hermesc
       - test_js:
           run_disabled_tests: false
       - test_android:
@@ -1241,8 +1246,9 @@ workflows:
           context: react-native-bot
           publish_npm_args: --release
           filters: *only_release_tags
-          requires:
-            - store-hermesc
+          # TODO: (hramos) Slim down Hermes Compiler files before adding to react-native npm
+          # requires:
+          #   - store-hermesc
 
   analysis:
     unless: << pipeline.parameters.run_package_release_workflow_only >>
@@ -1289,5 +1295,6 @@ workflows:
 
       - build_npm_package:
           publish_npm_args: --nightly
-          requires:
-            - store-hermesc
+          # TODO: (hramos) Slim down Hermes Compiler files before adding to react-native npm
+          # requires:
+          #   - store-hermesc