From 43bd29fb22b2b9993f68dc545bd1f84612e879ba Mon Sep 17 00:00:00 2001 From: acdlite Date: Wed, 3 May 2023 18:44:40 -0700 Subject: [PATCH] Gate DevTools test to fix CI (#26742) Summary: This test started failing recently in older versions of React because the Scheduler priority inside a microtask is Normal instead of Immediate. This is expected because microtasks are not Scheduler tasks; it's an implementation detail. I gated the test to only run in v17 because it's a regression test for legacy Suspense behavior, and the implementation details of the snapshot changed in v18. Test plan x--------- Using latest: ``` yarn test --build --project devtools --release-channel=experimental profilingcache ``` Using v17 (typically runs in a timed CI workflow): ``` /scripts/circleci/download_devtools_regression_build.js 17.0 --replaceBuild yarn test --build --project devtools --release-channel=experimental --reactVersion 17.0 profilingcache ``` DiffTrain build for commit https://github.com/facebook/react/commit/86b0e91998a04b22bb54a95d54f4a7632efa902f. Changelog: [Internal] << DO NOT EDIT BELOW THIS LINE >> Reviewed By: sammy-SC Differential Revision: D45424707 fbshipit-source-id: f3a761984c0ac53b5514f8ff51635bf6c4bab8f6 --- packages/react-native/Libraries/Renderer/REVISION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-native/Libraries/Renderer/REVISION b/packages/react-native/Libraries/Renderer/REVISION index 4f7cefe25ff..ac4da1ae465 100644 --- a/packages/react-native/Libraries/Renderer/REVISION +++ b/packages/react-native/Libraries/Renderer/REVISION @@ -1 +1 @@ -b12bea62d9cfd9a925f28cb2c93daeda3865a64e +86b0e91998a04b22bb54a95d54f4a7632efa902f