From 41f145fa47a338cb9daca0cc1d0e9dd0cc30b88a Mon Sep 17 00:00:00 2001 From: Nick Gerleman Date: Fri, 4 Jun 2021 13:13:47 -0700 Subject: [PATCH] Add testID to NewAppScreen Header Component (#31652) Summary: The RN OSS release process includes manual testing that a new template app can be started under various platforms, JS engines, etc. This should ideally be automated, to help reduce wasted engineer-time, and to allow reliably increasing release velocity. `react-native-windows` does already have tests to create and build template projects across our matrix, but they do not do any runtime validation on the newly created app. Adding a `testID` to the new app screen header gives us something to search for in black-box testing to validate that the app started successfully. This should help catch cases where a sample project in repo has changes not reflected in a newly created template app. ## Changelog [Internal] [Added] - Add testID to NewAppScreen Header Component Pull Request resolved: https://github.com/facebook/react-native/pull/31652 Test Plan: Did not manually validate the change, though did check that `ImageBackground` forwards props to `Image`, and that `Image` is aware of `testID` and will forward to the native component. Reviewed By: kacieb Differential Revision: D28907197 Pulled By: p-sun fbshipit-source-id: db3974294afba25878383f1955cad37b69d95da3 --- Libraries/NewAppScreen/components/Header.js | 1 + 1 file changed, 1 insertion(+) diff --git a/Libraries/NewAppScreen/components/Header.js b/Libraries/NewAppScreen/components/Header.js index 860ca274336..f8c186b5d5b 100644 --- a/Libraries/NewAppScreen/components/Header.js +++ b/Libraries/NewAppScreen/components/Header.js @@ -19,6 +19,7 @@ const Header = (): Node => { return (