Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Immediately destroy EventEmitterWrapper on update instead of waiting for GC

Browse Source 
Summary:
Immediately destroy EventEmitterWrapper on update instead of waiting for Java GC. This can resolve JSI::~Pointer deallocation crashes by clearing out EventEmitter and therefore EventTarget sooner, before RN teardown.

Changelog: [Internal]

Reviewed By: fkgozali

Differential Revision: D29415386

fbshipit-source-id: 05517bfd9e2cc2bd1b8c58d4f84c84f6f547268a
This commit is contained in:
Joshua Gross
2021-06-26 12:20:00 -07:00
committed by Facebook GitHub Bot
parent afafbf8ec4
commit 41ecccefcf
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java
+6
View File
@@ -805,7 +805,13 @@ public class SurfaceMountingManager {
viewState = new ViewState(reactTag, null, null);
mTagToViewState.put(reactTag, viewState);
}
EventEmitterWrapper previousEventEmitterWrapper = viewState.mEventEmitter;
viewState.mEventEmitter = eventEmitter;
// Immediately destroy native side of wrapper, instead of waiting for Java GC.
if (previousEventEmitterWrapper != eventEmitter && previousEventEmitterWrapper != null) {
previousEventEmitterWrapper.destroy();
}
}
@UiThread