From 41b17504bff606a3f822f2c888ec31fcccbc10e3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mateo=20Guzm=C3=A1n?= Date: Wed, 23 Apr 2025 05:38:35 -0700 Subject: [PATCH] Make `DrawerSlideEvent` internal (#50791) Summary: This class can be internalized as part of the initiative to reduce the public API surface. I've checked there are [no relevant OSS usages](https://github.com/search?type=code&q=NOT+is%3Afork+NOT+org%3Afacebook+NOT+repo%3Areact-native-tvos%2Freact-native-tvos+NOT+repo%3Anuagoz%2Freact-native+NOT+repo%3A2lambda123%2Freact-native+NOT+repo%3Abeanchips%2Ffacebookreactnative+NOT+repo%3AfabOnReact%2Freact-native-notes+NOT+user%3Ahuntie+NOT+user%3Acortinico+NOT+repo%3AMaxdev18%2Fpowersync_app+NOT+repo%3Acarter-0%2Finstagram-decompiled+NOT+repo%3Am0mosenpai%2Finstadamn+NOT+repo%3AA-Star100%2FA-Star100-AUG2-2024+NOT+repo%3Alclnrd%2Fdetox-scrollview-reproductible+NOT+repo%3ADionisisChytiris%2FWorldWiseTrivia_Main+NOT+repo%3Apast3l%2Fhi2+NOT+repo%3AoneDotpy%2FCaribouQuest+NOT+repo%3Abejayoharen%2Fdailytodo+NOT+repo%3Amolangning%2Freversing-discord+NOT+repo%3AScottPrzy%2Freact-native+NOT+repo%3Agabrieldonadel%2Freact-native-visionos+NOT+repo%3AGabriel2308%2FTestes-Soft+NOT+repo%3Adawnzs03%2FflakyBuild+NOT+repo%3Acga2351%2Fcode+NOT+repo%3Astreeg%2Ftcc+NOT+repo%3Asoftware-mansion-labs%2Freact-native-swiftui+NOT+repo%3Apkcsecurity%2Fdecompiled-lightbulb+com.facebook.react.views.drawer.events.DrawerSlideEvent). ## Changelog: [INTERNAL] - Make com.facebook.react.views.drawer.events.DrawerSlideEvent internal Pull Request resolved: https://github.com/facebook/react-native/pull/50791 Test Plan: ```bash yarn test-android yarn android ``` Reviewed By: cortinico, fabriziocucci Differential Revision: D73501596 Pulled By: javache fbshipit-source-id: f2c3d94e8a91c6b7666a30d3d9a465c57358d871 --- .../react-native/ReactAndroid/api/ReactAndroid.api | 12 ------------ .../react/views/drawer/events/DrawerSlideEvent.kt | 14 +++++++------- 2 files changed, 7 insertions(+), 19 deletions(-) diff --git a/packages/react-native/ReactAndroid/api/ReactAndroid.api b/packages/react-native/ReactAndroid/api/ReactAndroid.api index 634155d3bd4..462834eea56 100644 --- a/packages/react-native/ReactAndroid/api/ReactAndroid.api +++ b/packages/react-native/ReactAndroid/api/ReactAndroid.api @@ -5546,18 +5546,6 @@ public final class com/facebook/react/views/drawer/ReactDrawerLayoutManager : co public final class com/facebook/react/views/drawer/ReactDrawerLayoutManager$Companion { } -public final class com/facebook/react/views/drawer/events/DrawerSlideEvent : com/facebook/react/uimanager/events/Event { - public static final field Companion Lcom/facebook/react/views/drawer/events/DrawerSlideEvent$Companion; - public static final field EVENT_NAME Ljava/lang/String; - public fun (IF)V - public fun (IIF)V - public fun getEventName ()Ljava/lang/String; - public final fun getOffset ()F -} - -public final class com/facebook/react/views/drawer/events/DrawerSlideEvent$Companion { -} - public final class com/facebook/react/views/drawer/events/DrawerStateChangedEvent : com/facebook/react/uimanager/events/Event { public static final field Companion Lcom/facebook/react/views/drawer/events/DrawerStateChangedEvent$Companion; public static final field EVENT_NAME Ljava/lang/String; diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/drawer/events/DrawerSlideEvent.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/drawer/events/DrawerSlideEvent.kt index 34d7feaf283..d6c4d0ec837 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/drawer/events/DrawerSlideEvent.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/drawer/events/DrawerSlideEvent.kt @@ -13,21 +13,21 @@ import com.facebook.react.uimanager.common.ViewUtil import com.facebook.react.uimanager.events.Event /** Event emitted by a DrawerLayout as it is being moved open/closed. */ -public class DrawerSlideEvent : Event { +internal class DrawerSlideEvent : Event { private val offset: Float @Deprecated( "Use constructor with surfaceId", ReplaceWith("DrawerSlideEvent(surfaceId, viewId, offset)")) - public constructor(viewId: Int, offset: Float) : this(ViewUtil.NO_SURFACE_ID, viewId, offset) + constructor(viewId: Int, offset: Float) : this(ViewUtil.NO_SURFACE_ID, viewId, offset) - public constructor(surfaceId: Int, viewId: Int, offset: Float) : super(surfaceId, viewId) { + constructor(surfaceId: Int, viewId: Int, offset: Float) : super(surfaceId, viewId) { this.offset = offset } - public fun getOffset(): Float = offset + fun getOffset(): Float = offset - public override fun getEventName(): String = EVENT_NAME + override fun getEventName(): String = EVENT_NAME protected override fun getEventData(): WritableMap? { val eventData: WritableMap = Arguments.createMap() @@ -35,7 +35,7 @@ public class DrawerSlideEvent : Event { return eventData } - public companion object { - public const val EVENT_NAME: String = "topDrawerSlide" + companion object { + const val EVENT_NAME: String = "topDrawerSlide" } }