From 40c18e12599e1fd141091ae93fe8cfe124d2d2d2 Mon Sep 17 00:00:00 2001 From: Nicola Corti Date: Thu, 16 Jan 2025 11:00:59 -0800 Subject: [PATCH] Remove last tasks.creating invocation inside hermes-engine (#48739) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/48739 Follow-up to https://github.com/facebook/react-native/pull/48603 I realized there is one last `tasks.creating` invocation inside `hermes-engine` that needs migration. This fixes it. Changelog: [Internal] [Changed] - Reviewed By: alanleedev Differential Revision: D68276984 fbshipit-source-id: d58cf64cf41c7943464f15d12c7a04c3cc43ec7d --- .../ReactAndroid/hermes-engine/build.gradle.kts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/react-native/ReactAndroid/hermes-engine/build.gradle.kts b/packages/react-native/ReactAndroid/hermes-engine/build.gradle.kts index d8b0d5f382f..5e6019d12c9 100644 --- a/packages/react-native/ReactAndroid/hermes-engine/build.gradle.kts +++ b/packages/react-native/ReactAndroid/hermes-engine/build.gradle.kts @@ -90,21 +90,22 @@ val prefabHeadersDir = File("$buildDir/prefab-headers") // We inject the JSI directory used inside the Hermes build with the -DJSI_DIR config. val jsiDir = File(reactNativeRootDir, "ReactCommon/jsi") +val downloadHermesDest = File(downloadsDir, "hermes.tar.gz") val downloadHermes by - tasks.creating(Download::class) { + tasks.registering(Download::class) { src("https://github.com/facebook/hermes/tarball/${hermesVersion}") onlyIfModified(true) overwrite(true) quiet(true) useETag("all") retries(5) - dest(File(downloadsDir, "hermes.tar.gz")) + dest(downloadHermesDest) } val unzipHermes by tasks.registering(Copy::class) { dependsOn(downloadHermes) - from(tarTree(downloadHermes.dest)) { + from(tarTree(downloadHermesDest)) { eachFile { // We flatten the unzip as the tarball contains a `facebook-hermes-` // folder at the top level.