Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

call super instead of self

Browse Source 
Summary: Call super.setPadding. Calling the overriden version will cause stack overflow.

Differential Revision: D4096141
This commit is contained in:
Emil Sjolander
2016-12-19 13:40:35 -08:00
committed by Ahmed El-Helw
parent 242f5e9198
commit 3fff811c57
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/flat/FlatARTSurfaceViewShadowNode.java
+1 -1
View File
@@ -104,7 +104,7 @@ import com.facebook.react.views.art.ARTVirtualNode;
@Override
public void setPadding(int spacingType, float padding) {
if (getPadding(spacingType) != padding) {
setPadding(spacingType, padding);
super.setPadding(spacingType, padding);
mPaddingChanged = true;
dirty();
}
ReactAndroid/src/main/java/com/facebook/react/flat/FlatReactModalShadowNode.java
+1 -1
View File
@@ -87,7 +87,7 @@ class FlatReactModalShadowNode extends FlatShadowNode implements AndroidView {
@Override
public void setPadding(int spacingType, float padding) {
if (getPadding(spacingType) != padding) {
setPadding(spacingType, padding);
super.setPadding(spacingType, padding);
mPaddingChanged = true;
dirty();
}
ReactAndroid/src/main/java/com/facebook/react/flat/NativeViewWrapper.java
+1 -1
View File
@@ -103,7 +103,7 @@ import com.facebook.react.uimanager.ViewManager;
@Override
public void setPadding(int spacingType, float padding) {
if (getPadding(spacingType) != padding) {
setPadding(spacingType, padding);
super.setPadding(spacingType, padding);
mPaddingChanged = true;
dirty();
}