mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Rename DevSupportManagerImpl to BridgeDevSupportManager
Summary: ## Rationale See the description of D28978217. Changelog: [Internal] Reviewed By: sshic Differential Revision: D28978218 fbshipit-source-id: 29b9269b3d0e25171abaf6b74cacd0439f5c8ab5
This commit is contained in:
committed by
Facebook GitHub Bot
parent
f2e0b2f45f
commit
3feaecd473
+3
-3
@@ -40,9 +40,9 @@ import java.util.Map;
|
||||
* {@code <activity android:name="com.facebook.react.devsupport.DevSettingsActivity"/>}
|
||||
* {@code <uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/>}
|
||||
*/
|
||||
public final class DevSupportManagerImpl extends DevSupportManagerBase {
|
||||
public final class BridgeDevSupportManager extends DevSupportManagerBase {
|
||||
|
||||
public DevSupportManagerImpl(
|
||||
public BridgeDevSupportManager(
|
||||
Context applicationContext,
|
||||
ReactInstanceDevHelper reactInstanceDevHelper,
|
||||
@Nullable String packagerPathForJSBundleName,
|
||||
@@ -60,7 +60,7 @@ public final class DevSupportManagerImpl extends DevSupportManagerBase {
|
||||
null);
|
||||
}
|
||||
|
||||
public DevSupportManagerImpl(
|
||||
public BridgeDevSupportManager(
|
||||
Context applicationContext,
|
||||
ReactInstanceDevHelper reactInstanceManagerHelper,
|
||||
@Nullable String packagerPathForJSBundleName,
|
||||
+4
-4
@@ -17,14 +17,14 @@ import java.util.Map;
|
||||
|
||||
/**
|
||||
* A simple factory that creates instances of {@link DevSupportManager} implementations. Uses
|
||||
* reflection to create DevSupportManagerImpl if it exists. This allows ProGuard to strip that class
|
||||
* and its dependencies in release builds. If the class isn't found, {@link
|
||||
* reflection to create BridgeDevSupportManager if it exists. This allows ProGuard to strip that
|
||||
* class and its dependencies in release builds. If the class isn't found, {@link
|
||||
* DisabledDevSupportManager} is returned instead.
|
||||
*/
|
||||
public class DevSupportManagerFactory {
|
||||
|
||||
private static final String DEVSUPPORT_IMPL_PACKAGE = "com.facebook.react.devsupport";
|
||||
private static final String DEVSUPPORT_IMPL_CLASS = "DevSupportManagerImpl";
|
||||
private static final String DEVSUPPORT_IMPL_CLASS = "BridgeDevSupportManager";
|
||||
|
||||
public static DevSupportManager create(
|
||||
Context applicationContext,
|
||||
@@ -88,7 +88,7 @@ public class DevSupportManagerFactory {
|
||||
customPackagerCommandHandlers);
|
||||
} catch (Exception e) {
|
||||
throw new RuntimeException(
|
||||
"Requested enabled DevSupportManager, but DevSupportManagerImpl class was not found"
|
||||
"Requested enabled DevSupportManager, but BridgeDevSupportManager class was not found"
|
||||
+ " or could not be created",
|
||||
e);
|
||||
}
|
||||
|
||||
@@ -14,7 +14,7 @@ import com.facebook.react.devsupport.interfaces.ErrorType;
|
||||
import com.facebook.react.devsupport.interfaces.StackFrame;
|
||||
|
||||
/**
|
||||
* Interface used by {@link DevSupportManagerImpl} to allow interception on any redboxes during
|
||||
* Interface used by {@link BridgeDevSupportManager} to allow interception on any redboxes during
|
||||
* development and handling the information from the redbox. The implementation should be passed by
|
||||
* setRedBoxHandler in ReactInstanceManager.
|
||||
*/
|
||||
|
||||
+1
-1
@@ -17,7 +17,7 @@ import java.io.File;
|
||||
|
||||
/**
|
||||
* Interface for accessing and interacting with development features. In dev mode, use the
|
||||
* implementation {@link DevSupportManagerImpl}. In production mode, use the dummy implementation
|
||||
* implementation {@link BridgeDevSupportManager}. In production mode, use the dummy implementation
|
||||
* {@link DisabledDevSupportManager}.
|
||||
*/
|
||||
public interface DevSupportManager extends NativeModuleCallExceptionHandler {
|
||||
|
||||
Reference in New Issue
Block a user