From 3fd8a5bac5ff49791636e68bea1303e9105a27dc Mon Sep 17 00:00:00 2001 From: Sahil Jain Date: Wed, 19 Aug 2020 19:04:56 -0700 Subject: [PATCH] Remove unnecessary comment in BUCK files saying to change the contact field to the oncall of your team Summary: This comment shouldn't be committed, and should just be part of the template that generates new BUCK files. Changelog: [Internal] Differential Revision: D23225700 fbshipit-source-id: a1728e1a4ac0f3f94c4d1330d489bfae7a76a82d --- ReactAndroid/src/test/java/com/facebook/react/animated/BUCK | 1 - ReactAndroid/src/test/java/com/facebook/react/devsupport/BUCK | 1 - .../src/test/java/com/facebook/react/packagerconnection/BUCK | 1 - ReactAndroid/src/test/java/com/facebook/react/uimanager/BUCK | 1 - ReactAndroid/src/test/java/com/facebook/react/util/BUCK | 1 - ReactAndroid/src/test/java/com/facebook/react/views/BUCK | 1 - 6 files changed, 6 deletions(-) diff --git a/ReactAndroid/src/test/java/com/facebook/react/animated/BUCK b/ReactAndroid/src/test/java/com/facebook/react/animated/BUCK index c62728d5814..c25e292d64b 100644 --- a/ReactAndroid/src/test/java/com/facebook/react/animated/BUCK +++ b/ReactAndroid/src/test/java/com/facebook/react/animated/BUCK @@ -3,7 +3,6 @@ load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_tar rn_robolectric_test( name = "animated", srcs = glob(["**/*.java"]), - # Please change the contact to the oncall of your team contacts = ["oncall+fbandroid_sheriff@xmail.facebook.com"], visibility = [ "PUBLIC", diff --git a/ReactAndroid/src/test/java/com/facebook/react/devsupport/BUCK b/ReactAndroid/src/test/java/com/facebook/react/devsupport/BUCK index f720bc4aaf3..6fd2c2c49f5 100644 --- a/ReactAndroid/src/test/java/com/facebook/react/devsupport/BUCK +++ b/ReactAndroid/src/test/java/com/facebook/react/devsupport/BUCK @@ -3,7 +3,6 @@ load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_tar rn_robolectric_test( name = "devsupport", srcs = glob(["**/*.java"]), - # Please change the contact to the oncall of your team contacts = ["oncall+fbandroid_sheriff@xmail.facebook.com"], visibility = [ "PUBLIC", diff --git a/ReactAndroid/src/test/java/com/facebook/react/packagerconnection/BUCK b/ReactAndroid/src/test/java/com/facebook/react/packagerconnection/BUCK index f34e2c12e0e..18d466c38e3 100644 --- a/ReactAndroid/src/test/java/com/facebook/react/packagerconnection/BUCK +++ b/ReactAndroid/src/test/java/com/facebook/react/packagerconnection/BUCK @@ -3,7 +3,6 @@ load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_tar rn_robolectric_test( name = "packagerconnection", srcs = glob(["**/*.java"]), - # Please change the contact to the oncall of your team contacts = ["oncall+fbandroid_sheriff@xmail.facebook.com"], visibility = [ "PUBLIC", diff --git a/ReactAndroid/src/test/java/com/facebook/react/uimanager/BUCK b/ReactAndroid/src/test/java/com/facebook/react/uimanager/BUCK index bc96fa72a28..21a1e32104a 100644 --- a/ReactAndroid/src/test/java/com/facebook/react/uimanager/BUCK +++ b/ReactAndroid/src/test/java/com/facebook/react/uimanager/BUCK @@ -9,7 +9,6 @@ rn_robolectric_test( "MatrixMathHelperTest.java", "SimpleViewPropertyTest.java", ], - # Please change the contact to the oncall of your team contacts = ["oncall+fbandroid_sheriff@xmail.facebook.com"], is_androidx = True, visibility = [ diff --git a/ReactAndroid/src/test/java/com/facebook/react/util/BUCK b/ReactAndroid/src/test/java/com/facebook/react/util/BUCK index e1ef71382fe..039b88cc4e8 100644 --- a/ReactAndroid/src/test/java/com/facebook/react/util/BUCK +++ b/ReactAndroid/src/test/java/com/facebook/react/util/BUCK @@ -3,7 +3,6 @@ load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_tar rn_robolectric_test( name = "util", srcs = glob(["**/*.java"]), - # Please change the contact to the oncall of your team contacts = ["oncall+test_ownership_2020@xmail.facebook.com"], visibility = [ "PUBLIC", diff --git a/ReactAndroid/src/test/java/com/facebook/react/views/BUCK b/ReactAndroid/src/test/java/com/facebook/react/views/BUCK index 058829726fb..318274a05f0 100644 --- a/ReactAndroid/src/test/java/com/facebook/react/views/BUCK +++ b/ReactAndroid/src/test/java/com/facebook/react/views/BUCK @@ -5,7 +5,6 @@ rn_robolectric_test( # TODO Disabled temporarily until Yoga linking is fixed t14964130 # srcs = glob(['**/*.java']), srcs = glob(["image/*.java"]), - # Please change the contact to the oncall of your team contacts = ["oncall+fbandroid_sheriff@xmail.facebook.com"], deps = [ YOGA_TARGET,