From 3fb3ce4fa2080cdb7737184100040c15201484d4 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Sun, 27 Feb 2022 22:23:48 -0800 Subject: [PATCH] Delete TextMeasurement destructor Summary: TextMeasurement destructor is not necessary, we are deleting it changelog: [internal] internal Reviewed By: JoshuaGross Differential Revision: D34246015 fbshipit-source-id: 6ca4803fafc8b195828d546ba8fb45353257f383 --- .../react/renderer/textlayoutmanager/TextLayoutManager.cpp | 2 -- .../react/renderer/textlayoutmanager/TextLayoutManager.h | 1 - .../textlayoutmanager/platform/cxx/TextLayoutManager.cpp | 2 -- .../renderer/textlayoutmanager/platform/cxx/TextLayoutManager.h | 1 - 4 files changed, 6 deletions(-) diff --git a/ReactCommon/react/renderer/textlayoutmanager/platform/android/react/renderer/textlayoutmanager/TextLayoutManager.cpp b/ReactCommon/react/renderer/textlayoutmanager/platform/android/react/renderer/textlayoutmanager/TextLayoutManager.cpp index abc40602f4e..763e3c882c8 100644 --- a/ReactCommon/react/renderer/textlayoutmanager/platform/android/react/renderer/textlayoutmanager/TextLayoutManager.cpp +++ b/ReactCommon/react/renderer/textlayoutmanager/platform/android/react/renderer/textlayoutmanager/TextLayoutManager.cpp @@ -20,8 +20,6 @@ using namespace facebook::jni; namespace facebook { namespace react { -TextLayoutManager::~TextLayoutManager() = default; - void *TextLayoutManager::getNativeTextLayoutManager() const { return self_; } diff --git a/ReactCommon/react/renderer/textlayoutmanager/platform/android/react/renderer/textlayoutmanager/TextLayoutManager.h b/ReactCommon/react/renderer/textlayoutmanager/platform/android/react/renderer/textlayoutmanager/TextLayoutManager.h index ce47d36dcae..0088e57e779 100644 --- a/ReactCommon/react/renderer/textlayoutmanager/platform/android/react/renderer/textlayoutmanager/TextLayoutManager.h +++ b/ReactCommon/react/renderer/textlayoutmanager/platform/android/react/renderer/textlayoutmanager/TextLayoutManager.h @@ -34,7 +34,6 @@ class TextLayoutManager { contextContainer->at("EnableLargeTextMeasureCache") ? 1024 : kSimpleThreadSafeCacheSizeCap) {} - ~TextLayoutManager(); /* * Not copyable. diff --git a/ReactCommon/react/renderer/textlayoutmanager/platform/cxx/TextLayoutManager.cpp b/ReactCommon/react/renderer/textlayoutmanager/platform/cxx/TextLayoutManager.cpp index de9c2c95753..e0214a6dab0 100644 --- a/ReactCommon/react/renderer/textlayoutmanager/platform/cxx/TextLayoutManager.cpp +++ b/ReactCommon/react/renderer/textlayoutmanager/platform/cxx/TextLayoutManager.cpp @@ -10,8 +10,6 @@ namespace facebook { namespace react { -TextLayoutManager::~TextLayoutManager() {} - void *TextLayoutManager::getNativeTextLayoutManager() const { return (void *)this; } diff --git a/ReactCommon/react/renderer/textlayoutmanager/platform/cxx/TextLayoutManager.h b/ReactCommon/react/renderer/textlayoutmanager/platform/cxx/TextLayoutManager.h index b06e7592c3b..25233cabea2 100644 --- a/ReactCommon/react/renderer/textlayoutmanager/platform/cxx/TextLayoutManager.h +++ b/ReactCommon/react/renderer/textlayoutmanager/platform/cxx/TextLayoutManager.h @@ -29,7 +29,6 @@ using SharedTextLayoutManager = std::shared_ptr; class TextLayoutManager { public: TextLayoutManager(const ContextContainer::Shared &contextContainer) {} - ~TextLayoutManager(); /* * Measures `attributedStringBox` using native text rendering infrastructure.