Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Back out "Fixes Fabric related podspec"

Browse Source 
Summary:
Original commit changeset: 4b18a931a2e4

The original PR wherein these changes were introduced was problematic. When you expose headers that use C++ from the Yoga podspec, they get automatically imported in the Yoga umbrella file. This causes compilation errors, most likely because it's possible for non-c++ files to import these headers (i.e: RCTConvert.m).

I didn't dig into this too much, but since Fabric still doesn't fully compile in OSS, I think it's reasonable to revert this PR for now. cc Kevin Gozali.

Changelog:
[iOS][Fixed] - Undo Fabric-related podspec change

Reviewed By: fkgozali

Differential Revision: D18284536

fbshipit-source-id: a90454b945af0235424dc56408400cd35efd4e7a
This commit is contained in:
Ramanpreet Nara
2019-11-01 19:34:46 -07:00
committed by Facebook Github Bot
parent 56ad1bd38a
commit 3f50f57b3d
3 changed files with 4 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
React-Core.podspec
+2 -1
View File
@@ -64,7 +64,8 @@ Pod::Spec.new do |s|
"React/Views/RCTPicker*",
"React/Views/RCTRefreshControl*",
"React/Views/RCTSlider*",
"React/Views/RCTSwitch*"
"React/Views/RCTSwitch*",
ss.private_header_files = "React/Cxx*/*.h"
end
s.subspec "DevSupport" do |ss|