Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use density from provided context for SurfaceHandler

Browse Source 
Summary:
Changelog: [Internal]

We were using RN util to get pixel density, but it depends on the surface being created after venice instance is initialized. Given that we have context every time we update constraints, it makes sense to use it directly.

Reviewed By: mdvacca

Differential Revision: D26959430

fbshipit-source-id: 78701786efd82857812df689a725ba094fbd226e
This commit is contained in:
Andrei Shikov
2021-03-11 13:10:50 -08:00
committed by Facebook GitHub Bot
parent 5889cbebe3
commit 3ed133656f
2 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/fabric/SurfaceHandler.java
+2 -1
View File
@@ -43,5 +43,6 @@ public interface SurfaceHandler {
int offsetX,
int offsetY,
boolean doLeftAndRightSwapInRTL,
boolean isRTL);
boolean isRTL,
float pixelDensity);
}
ReactAndroid/src/main/java/com/facebook/react/fabric/SurfaceHandlerBinding.java
+10 -11
View File
@@ -22,13 +22,11 @@ public class SurfaceHandlerBinding implements SurfaceHandler {
private static final int NO_SURFACE_ID = 0;
@DoNotStrip private final HybridData mHybridData;
private final float mPixelDensity;
private static native HybridData initHybrid(int surfaceId, String moduleName);
public SurfaceHandlerBinding(String moduleName, float pixelDensity) {
public SurfaceHandlerBinding(String moduleName) {
mHybridData = initHybrid(NO_SURFACE_ID, moduleName);
mPixelDensity = pixelDensity;
}
@Override
@@ -80,17 +78,18 @@ public class SurfaceHandlerBinding implements SurfaceHandler {
int offsetX,
int offsetY,
boolean doLeftAndRightSwapInRTL,
boolean isRTL) {
boolean isRTL,
float pixelDensity) {
setLayoutConstraintsNative(
getMinSize(widthMeasureSpec) / mPixelDensity,
getMaxSize(widthMeasureSpec) / mPixelDensity,
getMinSize(heightMeasureSpec) / mPixelDensity,
getMaxSize(heightMeasureSpec) / mPixelDensity,
offsetX / mPixelDensity,
offsetY / mPixelDensity,
getMinSize(widthMeasureSpec) / pixelDensity,
getMaxSize(widthMeasureSpec) / pixelDensity,
getMinSize(heightMeasureSpec) / pixelDensity,
getMaxSize(heightMeasureSpec) / pixelDensity,
offsetX / pixelDensity,
offsetY / pixelDensity,
doLeftAndRightSwapInRTL,
isRTL,
mPixelDensity);
pixelDensity);
}
private native void setLayoutConstraintsNative(