From 3e02f1f929340dc184607bf9b25aadd648a54668 Mon Sep 17 00:00:00 2001 From: Ram N Date: Thu, 12 Sep 2019 11:45:57 -0700 Subject: [PATCH] Make View Managers lazy Summary: Today, View Managers are all initialized as soon as we start up the app. Making them lazy, so that we only intantiate them when they are really needed Differential Revision: D17329940 fbshipit-source-id: 821bf121f04d58c7b871c7923fed81d8c735f8b4 --- .../com/facebook/react/views/checkbox/ReactCheckBoxManager.java | 2 +- .../facebook/react/views/drawer/ReactDrawerLayoutManager.java | 2 +- .../facebook/react/views/textinput/ReactTextInputManager.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/checkbox/ReactCheckBoxManager.java b/ReactAndroid/src/main/java/com/facebook/react/views/checkbox/ReactCheckBoxManager.java index 7634e5160e6..4213ebc4dab 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/checkbox/ReactCheckBoxManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/checkbox/ReactCheckBoxManager.java @@ -24,7 +24,7 @@ import com.facebook.react.uimanager.annotations.ReactProp; /** View manager for {@link ReactCheckBox} components. */ public class ReactCheckBoxManager extends SimpleViewManager { - private static final String REACT_CLASS = "AndroidCheckBox"; + public static final String REACT_CLASS = "AndroidCheckBox"; private static final CompoundButton.OnCheckedChangeListener ON_CHECKED_CHANGE_LISTENER = new CompoundButton.OnCheckedChangeListener() { diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/drawer/ReactDrawerLayoutManager.java b/ReactAndroid/src/main/java/com/facebook/react/views/drawer/ReactDrawerLayoutManager.java index 99c8f259d39..961ab3f42f1 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/drawer/ReactDrawerLayoutManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/drawer/ReactDrawerLayoutManager.java @@ -36,7 +36,7 @@ import java.util.Map; @ReactModule(name = ReactDrawerLayoutManager.REACT_CLASS) public class ReactDrawerLayoutManager extends ViewGroupManager { - protected static final String REACT_CLASS = "AndroidDrawerLayout"; + public static final String REACT_CLASS = "AndroidDrawerLayout"; public static final int OPEN_DRAWER = 1; public static final int CLOSE_DRAWER = 2; diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java b/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java index d1b76b9f272..8c9e3209583 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java @@ -64,7 +64,7 @@ import java.util.Map; @ReactModule(name = ReactTextInputManager.REACT_CLASS) public class ReactTextInputManager extends BaseViewManager { public static final String TAG = ReactTextInputManager.class.getSimpleName(); - protected static final String REACT_CLASS = "AndroidTextInput"; + public static final String REACT_CLASS = "AndroidTextInput"; private static final int[] SPACING_TYPES = { Spacing.ALL, Spacing.LEFT, Spacing.RIGHT, Spacing.TOP, Spacing.BOTTOM,