From 3dc7b37cf73fe471db9dc6e432733af2073f0148 Mon Sep 17 00:00:00 2001 From: Nicola Corti Date: Fri, 28 Oct 2022 04:22:22 -0700 Subject: [PATCH] Sort parameters in DefaultNewArchitectureEntryPoint (#35115) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/35115 When looking at the new entry point I've realized we have the dynamicLibraryName as first parameter. As this API is not released yet, let's move it as last. So users on Java can easily call DefaultNewArchitectureEntryPoint.load(true, true, true) while now they will have to call DefaultNewArchitectureEntryPoint.load("...", true, true, true) Users in Kotlin won't be affected by this. Changelog: [Internal] [Changed] - Sort parameters in DefaultNewArchitectureEntryPoint Reviewed By: cipolleschi Differential Revision: D40793370 fbshipit-source-id: 9dc1569d76a1479a738f8e0f41a4183d7c04538f --- .../react/defaults/DefaultNewArchitectureEntryPoint.kt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/defaults/DefaultNewArchitectureEntryPoint.kt b/ReactAndroid/src/main/java/com/facebook/react/defaults/DefaultNewArchitectureEntryPoint.kt index f3552517f75..28ee848dd75 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/defaults/DefaultNewArchitectureEntryPoint.kt +++ b/ReactAndroid/src/main/java/com/facebook/react/defaults/DefaultNewArchitectureEntryPoint.kt @@ -25,10 +25,10 @@ object DefaultNewArchitectureEntryPoint { @JvmStatic @JvmOverloads fun load( - dynamicLibraryName: String = "appmodules", turboModulesEnabled: Boolean = true, fabricEnabled: Boolean = true, - concurrentReactEnabled: Boolean = true + concurrentReactEnabled: Boolean = true, + dynamicLibraryName: String = "appmodules", ) { ReactFeatureFlags.useTurboModules = turboModulesEnabled ReactFeatureFlags.enableFabricRenderer = fabricEnabled