From 3d20f49aff5a1af61921258ab1d80f598e021803 Mon Sep 17 00:00:00 2001
From: Ramanpreet Nara <ramanpreet@fb.com>
Date: Tue, 28 Apr 2020 14:30:15 -0700
Subject: [PATCH] Back out "Control concurrent calls into TMMDelegate from TMM"

Summary:
Original commit changeset: d22c4abfe87f

This synchronization is redundant. See D21025965.

Changelog: [Internal]

Reviewed By: fkgozali

Differential Revision: D21283284

fbshipit-source-id: dae737fe08bbc8f60913baa6c6a58228611257ef
---
 .../turbomodule/core/TurboModuleManager.java  | 22 +++++--------------
 1 file changed, 5 insertions(+), 17 deletions(-)

diff --git a/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/TurboModuleManager.java b/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/TurboModuleManager.java
index 004c8e8a740..1b97c5bd62d 100644
--- a/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/TurboModuleManager.java
+++ b/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/TurboModuleManager.java
@@ -32,7 +32,7 @@ import java.util.*;
  */
 public class TurboModuleManager implements JSIModule, TurboModuleRegistry {
   private static volatile boolean sIsSoLibraryLoaded;
-  private final List<String> mEagerInitModuleNames = new ArrayList<>();
+  private final List<String> mEagerInitModuleNames;
   private final TurboModuleProvider mJavaModuleProvider;
   private final TurboModuleProvider mCxxModuleProvider;
 
@@ -64,11 +64,8 @@ public class TurboModuleManager implements JSIModule, TurboModuleRegistry {
             delegate);
     installJSIBindings();
 
-    if (delegate != null) {
-      synchronized (delegate) {
-        mEagerInitModuleNames.addAll(delegate.getEagerInitModuleNames());
-      }
-    }
+    mEagerInitModuleNames =
+        delegate == null ? new ArrayList<String>() : delegate.getEagerInitModuleNames();
 
     mJavaModuleProvider =
         new TurboModuleProvider() {
@@ -78,10 +75,7 @@ public class TurboModuleManager implements JSIModule, TurboModuleRegistry {
               return null;
             }
 
-            /** TODO(T65532092): Should TurboModuleManagerDelegate be thread-safe? */
-            synchronized (delegate) {
-              return delegate.getModule(moduleName);
-            }
+            return delegate.getModule(moduleName);
           }
         };
 
@@ -93,13 +87,7 @@ public class TurboModuleManager implements JSIModule, TurboModuleRegistry {
               return null;
             }
 
-            CxxModuleWrapper nativeModule;
-
-            /** TODO(T65532092): Should TurboModuleManagerDelegate be thread-safe? */
-            synchronized (delegate) {
-              nativeModule = delegate.getLegacyCxxModule(moduleName);
-            }
-
+            CxxModuleWrapper nativeModule = delegate.getLegacyCxxModule(moduleName);
             if (nativeModule != null) {
               // TurboModuleManagerDelegate must always return TurboModules
               Assertions.assertCondition(