From 3d1c1b50fed369fa64c7204233f1336de7776146 Mon Sep 17 00:00:00 2001 From: Samuel Susla Date: Thu, 20 Feb 2025 08:25:29 -0800 Subject: [PATCH] remove incorrect call of removeObserver from RCTDeviceInfo (#49551) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/49551 changelog: [internal] in recent commit, https://github.com/facebook/react-native/commit/470bc4088957920aa55c8e5ccf3c9f4259c0694c, use of KVO was removed. But `removeObserver` when `addObserver` was not called leads to a crash and must be removed as well. Reviewed By: cipolleschi Differential Revision: D69918158 fbshipit-source-id: ad65273e74545eba77ab35c5e22c28bddf072f9f --- packages/react-native/React/CoreModules/RCTDeviceInfo.mm | 4 ---- 1 file changed, 4 deletions(-) diff --git a/packages/react-native/React/CoreModules/RCTDeviceInfo.mm b/packages/react-native/React/CoreModules/RCTDeviceInfo.mm index 101438a0668..8761904c55b 100644 --- a/packages/react-native/React/CoreModules/RCTDeviceInfo.mm +++ b/packages/react-native/React/CoreModules/RCTDeviceInfo.mm @@ -33,8 +33,6 @@ using namespace facebook::react; std::atomic _invalidated; } -static NSString *const kFrameKeyPath = @"frame"; - @synthesize moduleRegistry = _moduleRegistry; RCT_EXPORT_MODULE() @@ -122,8 +120,6 @@ RCT_EXPORT_MODULE() [[NSNotificationCenter defaultCenter] removeObserver:self name:RCTBridgeWillInvalidateModulesNotification object:nil]; - [RCTKeyWindow() removeObserver:self forKeyPath:kFrameKeyPath]; - #if TARGET_OS_IOS [[NSNotificationCenter defaultCenter] removeObserver:self name:UIDeviceOrientationDidChangeNotification object:nil]; #endif