From 3d06f9e449dc78f379e630a8093e15b0f9dc2bd0 Mon Sep 17 00:00:00 2001 From: Nicola Corti Date: Fri, 6 Jun 2025 06:58:11 -0700 Subject: [PATCH] Back out "Override `updateRuntimeShadowNodeReferencesOnCommit` for OSS" (#51839) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/51839 Original commit changeset: 4394a2370d9e Original Phabricator Diff: D73771648 Changelog: [Internal] - Reviewed By: lenaic, sammy-SC Differential Revision: D76038710 fbshipit-source-id: b4d61bef476e8b903432511939cce65e881689c5 --- .../ReactNativeFeatureFlagsOverrides_RNOSS_Stable_Android.kt | 2 -- .../featureflags/ReactNativeFeatureFlagsOverridesOSSStable.h | 3 --- 2 files changed, 5 deletions(-) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsOverrides_RNOSS_Stable_Android.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsOverrides_RNOSS_Stable_Android.kt index 50282190296..f47d8198fbd 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsOverrides_RNOSS_Stable_Android.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsOverrides_RNOSS_Stable_Android.kt @@ -18,7 +18,5 @@ public class ReactNativeFeatureFlagsOverrides_RNOSS_Stable_Android( override fun useTurboModules(): Boolean = bridgelessEnabled || turboModulesEnabled - override fun updateRuntimeShadowNodeReferencesOnCommit(): Boolean = true - override fun useShadowNodeStateOnClone(): Boolean = true } diff --git a/packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsOverridesOSSStable.h b/packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsOverridesOSSStable.h index 8f3e23de559..f165dda8753 100644 --- a/packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsOverridesOSSStable.h +++ b/packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsOverridesOSSStable.h @@ -26,9 +26,6 @@ class ReactNativeFeatureFlagsOverridesOSSStable bool useNativeViewConfigsInBridgelessMode() override { return true; } - bool updateRuntimeShadowNodeReferencesOnCommit() override { - return true; - } bool useShadowNodeStateOnClone() override { return true; }