From 3cd46b953494aeaa94a8d7b0e3f470dd9234db94 Mon Sep 17 00:00:00 2001 From: Nicola Corti Date: Tue, 1 Oct 2024 10:04:57 -0700 Subject: [PATCH] Do not reference `setTranslucentBackgroundDrawable` (#46754) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/46754 This method has been deprecated since 0.76, but we're still using it inside our codebase. I'm cleaning up the only usage of it replacing it with the implementation. Changelog: [Internal] [Changed] - Do not reference `setTranslucentBackgroundDrawable` Reviewed By: cipolleschi Differential Revision: D63695933 fbshipit-source-id: d39b13b584d3ac1406c61c3bf86b86b05dc984d9 --- .../facebook/react/views/view/ReactViewManager.java | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewManager.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewManager.java index 548fe524399..6db5ca3f869 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewManager.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewManager.java @@ -8,6 +8,7 @@ package com.facebook.react.views.view; import android.graphics.Rect; +import android.graphics.drawable.Drawable; import android.view.View; import androidx.annotation.ColorInt; import androidx.annotation.Nullable; @@ -228,10 +229,13 @@ public class ReactViewManager extends ReactClippingViewManager { @ReactProp(name = "nativeBackgroundAndroid") public void setNativeBackground(ReactViewGroup view, @Nullable ReadableMap bg) { - view.setTranslucentBackgroundDrawable( - bg == null - ? null - : ReactDrawableHelper.createDrawableFromJSDescription(view.getContext(), bg)); + Drawable background; + if (bg != null) { + background = ReactDrawableHelper.createDrawableFromJSDescription(view.getContext(), bg); + } else { + background = null; + } + BackgroundStyleApplicator.setFeedbackUnderlay(view, background); } @ReactProp(name = "nativeForegroundAndroid")