From 3b8fbc336c8fcd5d46a04070cbcfef55e38e82a3 Mon Sep 17 00:00:00 2001 From: Samuel Susla Date: Mon, 29 Mar 2021 10:23:55 -0700 Subject: [PATCH] Use default value instead of abort when parsing color Summary: changelog: [internal] Fabric is missing implementation of PlatformColor APIs. If it is used, it causes a crash. Until it is implemented, let's remove abort statement and continue with transparent color. Reviewed By: mdvacca Differential Revision: D27395917 fbshipit-source-id: 50d541c5cacc10a7652f7f1ddc97e086a4ba8f03 --- ReactCommon/react/renderer/graphics/conversions.h | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/ReactCommon/react/renderer/graphics/conversions.h b/ReactCommon/react/renderer/graphics/conversions.h index f3420295b2e..a80eda0b63e 100644 --- a/ReactCommon/react/renderer/graphics/conversions.h +++ b/ReactCommon/react/renderer/graphics/conversions.h @@ -20,10 +20,10 @@ namespace react { #pragma mark - Color inline void fromRawValue(const RawValue &value, SharedColor &result) { - float red; - float green; - float blue; - float alpha; + float red = 0; + float green = 0; + float blue = 0; + float alpha = 0; if (value.hasType()) { auto argb = (int64_t)value; @@ -40,9 +40,8 @@ inline void fromRawValue(const RawValue &value, SharedColor &result) { green = items.at(1); blue = items.at(2); alpha = length == 4 ? items.at(3) : 1.0f; - } else { - abort(); } + result = colorFromComponents({red, green, blue, alpha}); }