From 399285f91c2f675dea16fe61a86049ef7fecf35b Mon Sep 17 00:00:00 2001
From: Kacie Bawiec <kacieb@fb.com>
Date: Thu, 3 Jun 2021 14:42:47 -0700
Subject: [PATCH] Localize "search", "button", and "togglebutton" accessibility
 roles by using the platform roles

Summary:
Several accessibilityRole strings are hardcoded to only English on Android. Swap them to just use the platform constants. This way, TalkBack will handle translations.

This change swaps roles "search", "button", and "togglebutton" roles to use the platform description.

Changelog:
[Android][Changed] Localize "search", "button", and "togglebutton" accessibility roles by using the platform roles

Reviewed By: lunaleaps

Differential Revision: D28077246

fbshipit-source-id: 5b88a6fd7e78b3426506f253b823ecca0608c4bc
---
 .../react/uimanager/ReactAccessibilityDelegate.java  |  4 ----
 .../views/uimanager/values/strings_unlocalized.xml   | 12 ------------
 2 files changed, 16 deletions(-)

diff --git a/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactAccessibilityDelegate.java b/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactAccessibilityDelegate.java
index b87e976ef62..78c83a38611 100644
--- a/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactAccessibilityDelegate.java
+++ b/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactAccessibilityDelegate.java
@@ -385,18 +385,14 @@ public class ReactAccessibilityDelegate extends AccessibilityDelegateCompat {
         spannable.setSpan(new URLSpan(""), 0, spannable.length(), 0);
         nodeInfo.setText(spannable);
       }
-    } else if (role.equals(AccessibilityRole.SEARCH)) {
-      nodeInfo.setRoleDescription(context.getString(R.string.search_description));
     } else if (role.equals(AccessibilityRole.IMAGE)) {
       nodeInfo.setRoleDescription(context.getString(R.string.image_description));
     } else if (role.equals(AccessibilityRole.IMAGEBUTTON)) {
       nodeInfo.setRoleDescription(context.getString(R.string.imagebutton_description));
       nodeInfo.setClickable(true);
     } else if (role.equals(AccessibilityRole.BUTTON)) {
-      nodeInfo.setRoleDescription(context.getString(R.string.button_description));
       nodeInfo.setClickable(true);
     } else if (role.equals(AccessibilityRole.TOGGLEBUTTON)) {
-      nodeInfo.setRoleDescription(context.getString(R.string.toggle_button_description));
       nodeInfo.setClickable(true);
       nodeInfo.setCheckable(true);
     } else if (role.equals(AccessibilityRole.SUMMARY)) {
diff --git a/ReactAndroid/src/main/res/views/uimanager/values/strings_unlocalized.xml b/ReactAndroid/src/main/res/views/uimanager/values/strings_unlocalized.xml
index 2d239fdbd93..d06603f6113 100644
--- a/ReactAndroid/src/main/res/views/uimanager/values/strings_unlocalized.xml
+++ b/ReactAndroid/src/main/res/views/uimanager/values/strings_unlocalized.xml
@@ -4,22 +4,10 @@
     name="link_description"
     translatable="false"
     >Link</string>
-  <string
-    name="search_description"
-    translatable="false"
-    >Search Field</string>
   <string
     name="image_description"
     translatable="false"
     >Image</string>
-  <string
-    name="button_description"
-    translatable="false"
-    >Button</string>
-  <string
-    name="toggle_button_description"
-    translatable="false"
-    >Toggle Button</string>
   <string
     name="imagebutton_description"
     translatable="false"