mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Fix npm package build for docs-only changes (#57719)
Summary: The build_npm_package job uses always() so it can run when one platform-specific prerequisite is skipped. However, that also caused it to run when every artifact-producing prerequisite was skipped, as happens for Markdown-only pull requests. It then failed because there were no artifacts to download. Require at least one Android or Apple artifact-producing prerequisite to have succeeded before running the package build. Failing run: https://github.com/react/react-native/actions/runs/30290299313/job/90058215494?pr=57703 ## Changelog: [INTERNAL] [FIXED] - Skip the npm package build when all artifact-producing prerequisites are skipped Pull Request resolved: https://github.com/react/react-native/pull/57719 Test Plan: - ./node_modules/.bin/prettier --check .github/workflows/test-all.yml - Parsed .github/workflows/test-all.yml with Ruby YAML - git diff --check Reviewed By: cortinico Differential Revision: D113900588 Pulled By: cipolleschi fbshipit-source-id: f6979ca48b44cf807bf4db12e3c0106d720a9cb1
This commit is contained in:
1 parent
54656471a5
commit
3958c7fa97
1 file changed
+4
-1
@@ -325,7 +325,10 @@ jobs:
|
||||
if: |
|
||||
always() &&
|
||||
!contains(needs.*.result, 'failure') &&
|
||||
!contains(needs.*.result, 'cancelled')
|
||||
!contains(needs.*.result, 'cancelled') &&
|
||||
(needs.build_android.result == 'success' ||
|
||||
needs.prebuild_apple_dependencies.result == 'success' ||
|
||||
needs.prebuild_react_native_core.result == 'success')
|
||||
container:
|
||||
image: reactnativecommunity/react-native-android:latest
|
||||
env:
|
||||
|
||||
Reference in new issue
Block a user