From 379a2729f1b623f768f10cb8891060a2a75d3bc9 Mon Sep 17 00:00:00 2001 From: Andrew Datsenko Date: Mon, 8 Apr 2024 17:13:00 -0700 Subject: [PATCH] //xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/unimplementedview:unimplementedviewAndroid (#43970) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/43970 Changelog: [Internal] Reviewed By: cortinico Differential Revision: D55725588 fbshipit-source-id: e7c5a9b0fad05c7de65115a69571725ce6b91640 --- .../ReactAndroid/api/ReactAndroid.api | 11 +++-- .../ReactUnimplementedViewManager.java | 41 ------------------- .../ReactUnimplementedViewManager.kt | 33 +++++++++++++++ 3 files changed, 40 insertions(+), 45 deletions(-) delete mode 100644 packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/unimplementedview/ReactUnimplementedViewManager.java create mode 100644 packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/unimplementedview/ReactUnimplementedViewManager.kt diff --git a/packages/react-native/ReactAndroid/api/ReactAndroid.api b/packages/react-native/ReactAndroid/api/ReactAndroid.api index 430d2e2e798..bd561e1a1a8 100644 --- a/packages/react-native/ReactAndroid/api/ReactAndroid.api +++ b/packages/react-native/ReactAndroid/api/ReactAndroid.api @@ -7632,13 +7632,13 @@ public final class com/facebook/react/views/unimplementedview/ReactUnimplemented public final fun setName (Ljava/lang/String;)V } -public class com/facebook/react/views/unimplementedview/ReactUnimplementedViewManager : com/facebook/react/uimanager/ViewGroupManager { +public final class com/facebook/react/views/unimplementedview/ReactUnimplementedViewManager : com/facebook/react/uimanager/ViewGroupManager { + public static final field Companion Lcom/facebook/react/views/unimplementedview/ReactUnimplementedViewManager$Companion; public static final field REACT_CLASS Ljava/lang/String; public fun ()V - protected synthetic fun createViewInstance (Lcom/facebook/react/uimanager/ThemedReactContext;)Landroid/view/View; - protected fun createViewInstance (Lcom/facebook/react/uimanager/ThemedReactContext;)Lcom/facebook/react/views/unimplementedview/ReactUnimplementedView; + public synthetic fun createViewInstance (Lcom/facebook/react/uimanager/ThemedReactContext;)Landroid/view/View; public fun getName ()Ljava/lang/String; - public fun setName (Lcom/facebook/react/views/unimplementedview/ReactUnimplementedView;Ljava/lang/String;)V + public final fun setName (Lcom/facebook/react/views/unimplementedview/ReactUnimplementedView;Ljava/lang/String;)V } public class com/facebook/react/views/unimplementedview/ReactUnimplementedViewManager$$PropsSetter : com/facebook/react/uimanager/ViewManagerPropertyUpdater$ViewManagerSetter { @@ -7648,6 +7648,9 @@ public class com/facebook/react/views/unimplementedview/ReactUnimplementedViewMa public fun setProperty (Lcom/facebook/react/views/unimplementedview/ReactUnimplementedViewManager;Lcom/facebook/react/views/unimplementedview/ReactUnimplementedView;Ljava/lang/String;Ljava/lang/Object;)V } +public final class com/facebook/react/views/unimplementedview/ReactUnimplementedViewManager$Companion { +} + public final class com/facebook/react/views/view/ColorUtil { public static final field INSTANCE Lcom/facebook/react/views/view/ColorUtil; public static final fun getOpacityFromColor (I)I diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/unimplementedview/ReactUnimplementedViewManager.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/unimplementedview/ReactUnimplementedViewManager.java deleted file mode 100644 index 80c4c1a3727..00000000000 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/unimplementedview/ReactUnimplementedViewManager.java +++ /dev/null @@ -1,41 +0,0 @@ -/* - * Copyright (c) Meta Platforms, Inc. and affiliates. - * - * This source code is licensed under the MIT license found in the - * LICENSE file in the root directory of this source tree. - */ - -package com.facebook.react.views.unimplementedview; - -import static com.facebook.react.views.unimplementedview.ReactUnimplementedViewManager.REACT_CLASS; - -import androidx.annotation.Nullable; -import com.facebook.react.module.annotations.ReactModule; -import com.facebook.react.uimanager.ThemedReactContext; -import com.facebook.react.uimanager.ViewGroupManager; -import com.facebook.react.uimanager.annotations.ReactProp; - -/** - * ViewManager for {@link ReactUnimplementedView} to represent a component that is not yet - * supported. - */ -@ReactModule(name = ReactUnimplementedViewManager.REACT_CLASS) -public class ReactUnimplementedViewManager extends ViewGroupManager { - - public static final String REACT_CLASS = "UnimplementedNativeView"; - - @Override - protected ReactUnimplementedView createViewInstance(ThemedReactContext reactContext) { - return new ReactUnimplementedView(reactContext); - } - - @Override - public String getName() { - return REACT_CLASS; - } - - @ReactProp(name = "name") - public void setName(ReactUnimplementedView view, @Nullable String name) { - view.setName(name); - } -} diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/unimplementedview/ReactUnimplementedViewManager.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/unimplementedview/ReactUnimplementedViewManager.kt new file mode 100644 index 00000000000..55f9548a982 --- /dev/null +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/unimplementedview/ReactUnimplementedViewManager.kt @@ -0,0 +1,33 @@ +/* + * Copyright (c) Meta Platforms, Inc. and affiliates. + * + * This source code is licensed under the MIT license found in the + * LICENSE file in the root directory of this source tree. + */ + +package com.facebook.react.views.unimplementedview + +import com.facebook.react.module.annotations.ReactModule +import com.facebook.react.uimanager.ThemedReactContext +import com.facebook.react.uimanager.ViewGroupManager +import com.facebook.react.uimanager.annotations.ReactProp + +/** ViewManager for [ReactUnimplementedView] to represent a component that is not yet supported. */ +@ReactModule(name = ReactUnimplementedViewManager.REACT_CLASS) +public class ReactUnimplementedViewManager : ViewGroupManager() { + + protected override fun createViewInstance( + reactContext: ThemedReactContext + ): ReactUnimplementedView = ReactUnimplementedView(reactContext) + + public override fun getName(): String = REACT_CLASS + + @ReactProp(name = "name") + public fun setName(view: ReactUnimplementedView, name: String) { + view.setName(name) + } + + public companion object { + public const val REACT_CLASS: String = "UnimplementedNativeView" + } +}