Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add null check for gesture ended notifier

Browse Source 
Summary:
The `notifyNativeGestureEnded` API is added to notify user gesture ended, so that any optimization we had during handling the gesture can be restored.

It's possible that when the gesture finishes, the RootView is already unmounted from the native side. This might happen when user starts a gesture that caused leave of the RN screen, or close the app.

Changelog:
[Android][Internal] - Avoid NPE for gesture notifier

Reviewed By: javache

Differential Revision: D35902523

fbshipit-source-id: 9bb5819a53dd053290031eebaae1b8f0318ae534
This commit is contained in:
Xin Chen
2022-04-26 14:18:17 -07:00
committed by Facebook GitHub Bot
parent 1a3eaa5dbf
commit 36c4e42d82
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/uimanager/events/NativeGestureUtil.java
+5 -1
View File
@@ -9,6 +9,7 @@ package com.facebook.react.uimanager.events;
import android.view.MotionEvent;
import android.view.View;
import com.facebook.react.uimanager.RootView;
import com.facebook.react.uimanager.RootViewUtil;
/** Utilities for native Views that interpret native gestures (e.g. ScrollView, ViewPager, etc.). */
@@ -35,6 +36,9 @@ public class NativeGestureUtil {
* @param event the MotionEvent that caused the gesture to be ended
*/
public static void notifyNativeGestureEnded(View view, MotionEvent event) {
RootViewUtil.getRootView(view).onChildEndedNativeGesture(view, event);
RootView rootView = RootViewUtil.getRootView(view);
if (rootView != null) {
rootView.onChildEndedNativeGesture(view, event);
}
}
}