From 3630138dcced83b360f064ce030dfe8bccce542e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Oskar=20Kwas=CC=81niewski?= <oskarkwasniewski@icloud.com>
Date: Thu, 11 Jan 2024 07:13:05 -0800
Subject: [PATCH] remove old architecture pipeline for RNTester (#42245)

Summary:
As discussed with cipolleschi, RNTester shouldn't be tested for Old Arch. This PR removes those unnecessary pipeline runs

## Changelog:

[INTERNAL] [REMOVED] - remove old architecture pipeline for RNTester

Pull Request resolved: https://github.com/facebook/react-native/pull/42245

Test Plan: CI Green

Reviewed By: cortinico

Differential Revision: D52694176

Pulled By: cipolleschi

fbshipit-source-id: a607bac4659b0611d5f49b5e45134f896bb96a91
---
 .circleci/configurations/jobs.yml                   | 13 +++----------
 .circleci/configurations/test_workflows/testAll.yml |  3 ---
 .circleci/configurations/test_workflows/testIOS.yml |  3 ---
 3 files changed, 3 insertions(+), 16 deletions(-)

diff --git a/.circleci/configurations/jobs.yml b/.circleci/configurations/jobs.yml
index f8eb1d0e7af..4d5b601841f 100644
--- a/.circleci/configurations/jobs.yml
+++ b/.circleci/configurations/jobs.yml
@@ -503,11 +503,6 @@ jobs:
         description: Which JavaScript engine to use. Must be one of "Hermes", "JSC".
         type: enum
         enum: ["Hermes", "JSC"]
-      architecture:
-        default: "OldArch"
-        description: Which React Native architecture to use. Must be one of "OldArch", "NewArch".
-        type: enum
-        enum: ["NewArch", "OldArch"]
       use_frameworks:
         default: "StaticLibraries"
         description: The dependency building and linking strategy to use. Must be one of "StaticLibraries", "DynamicFrameworks"
@@ -550,11 +545,8 @@ jobs:
             - with_xcodebuild_cache:
                 steps:
                   - run:
-                      name: Install CocoaPods dependencies - Architecture << parameters.architecture >>
+                      name: Install CocoaPods dependencies
                       command: |
-                        if [[ << parameters.architecture >> == "NewArch" ]]; then
-                          export RCT_NEW_ARCH_ENABLED=1
-                        fi
 
                         if [[ << parameters.jsengine >> == "JSC" ]]; then
                           export USE_HERMES=0
@@ -564,8 +556,9 @@ jobs:
                           export USE_FRAMEWORKS=dynamic
                         fi
 
+                        export RCT_NEW_ARCH_ENABLED=1
                         cd packages/rn-tester
-
+                        
                         bundle install
                         bundle exec pod install
                   - when:
diff --git a/.circleci/configurations/test_workflows/testAll.yml b/.circleci/configurations/test_workflows/testAll.yml
index 7afd7d2171f..305dc16ce0a 100644
--- a/.circleci/configurations/test_workflows/testAll.yml
+++ b/.circleci/configurations/test_workflows/testAll.yml
@@ -80,10 +80,8 @@
             - build_hermes_macos
           name: "Test RNTester with Ruby 3.2.0"
           ruby_version: "3.2.0"
-          architecture: "NewArch"
           executor: reactnativeios-lts
       - test_ios_rntester:
-          architecture: "NewArch"
           requires:
             - build_hermes_macos
           matrix:
@@ -108,5 +106,4 @@
             - build_hermes_macos
           matrix:
             parameters:
-              architecture: ["OldArch", "NewArch"]
               jsengine: ["Hermes", "JSC"]
diff --git a/.circleci/configurations/test_workflows/testIOS.yml b/.circleci/configurations/test_workflows/testIOS.yml
index eb6cf50a527..1ea8e9cdc1e 100644
--- a/.circleci/configurations/test_workflows/testIOS.yml
+++ b/.circleci/configurations/test_workflows/testIOS.yml
@@ -71,10 +71,8 @@
             - build_hermes_macos
           name: "Test RNTester with Ruby 3.2.0"
           ruby_version: "3.2.0"
-          architecture: "NewArch"
           executor: reactnativeios-lts
       - test_ios_rntester:
-          architecture: "NewArch"
           requires:
             - build_hermes_macos
           matrix:
@@ -99,5 +97,4 @@
             - build_hermes_macos
           matrix:
             parameters:
-              architecture: ["NewArch", "OldArch"]
               jsengine: ["Hermes", "JSC"]