From 3508017fb3c1128b1adee06f268211f92855385a Mon Sep 17 00:00:00 2001 From: Will Holen Date: Mon, 2 Mar 2020 14:47:28 -0800 Subject: [PATCH] Remove unconditional assert from addNativeTracingHooks. Do nothing instead. Summary: This line was and apparently has always been triggered from the HermesExecutorFactory. We just didn't notice because we didn't build with assertions. Changelog: [Internal] Don't crash on load when assertions and Hermes are enabled Reviewed By: dulinriley Differential Revision: D20163138 fbshipit-source-id: af672bb51eeb1833f3e27ad9a00921731c345fc5 --- .../main/java/com/facebook/hermes/reactexecutor/JSITracing.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ReactAndroid/src/main/java/com/facebook/hermes/reactexecutor/JSITracing.cpp b/ReactAndroid/src/main/java/com/facebook/hermes/reactexecutor/JSITracing.cpp index 763ed1ce69a..58f910f2826 100644 --- a/ReactAndroid/src/main/java/com/facebook/hermes/reactexecutor/JSITracing.cpp +++ b/ReactAndroid/src/main/java/com/facebook/hermes/reactexecutor/JSITracing.cpp @@ -10,7 +10,7 @@ namespace facebook { namespace jsi { void addNativeTracingHooks(Runtime &rt) { - assert(false && "unimplemented"); + // Unimplemented } } // namespace jsi } // namespace facebook