From 3426591bbef1d6a1966c979ada326a11596eda2b Mon Sep 17 00:00:00 2001 From: Moti Zilberman Date: Wed, 17 Apr 2024 05:22:09 -0700 Subject: [PATCH] Tweak pause overlay design, remove Step Over button (#44119) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/44119 Changelog: [Internal] TSIA - following design feedback from huntie. Reviewed By: hoxyq Differential Revision: D56193523 fbshipit-source-id: 89e9fc77702e40a2f39be719c700fe9ad400a8a2 --- .../ReactAndroid/api/ReactAndroid.api | 2 -- .../facebook/react/ReactInstanceManager.java | 8 ------ .../ReactInstanceManagerInspectorTarget.java | 2 -- .../devsupport/DevSupportManagerBase.java | 4 +-- .../interfaces/DevSupportManager.kt | 2 -- .../facebook/react/runtime/ReactHostImpl.java | 8 ------ .../react/runtime/ReactHostInspectorTarget.kt | 2 -- .../ReactInstanceManagerInspectorTarget.cpp | 13 --------- .../jni/ReactInstanceManagerInspectorTarget.h | 1 - .../runtime/jni/JReactHostInspectorTarget.cpp | 13 --------- .../runtime/jni/JReactHostInspectorTarget.h | 1 - .../devsupport/drawable-hdpi/ic_step_over.png | Bin 764 -> 0 bytes .../devsupport/drawable-mdpi/ic_step_over.png | Bin 439 -> 0 bytes .../drawable-xhdpi/ic_step_over.png | Bin 908 -> 0 bytes .../drawable-xxhdpi/ic_step_over.png | Bin 1670 -> 0 bytes .../drawable-xxxhdpi/ic_step_over.png | Bin 2059 -> 0 bytes .../paused_in_debugger_background.xml | 27 ++++++++++++++++++ .../layout/paused_in_debugger_view.xml | 18 ++---------- 18 files changed, 30 insertions(+), 71 deletions(-) delete mode 100644 packages/react-native/ReactAndroid/src/main/res/devsupport/drawable-hdpi/ic_step_over.png delete mode 100644 packages/react-native/ReactAndroid/src/main/res/devsupport/drawable-mdpi/ic_step_over.png delete mode 100644 packages/react-native/ReactAndroid/src/main/res/devsupport/drawable-xhdpi/ic_step_over.png delete mode 100644 packages/react-native/ReactAndroid/src/main/res/devsupport/drawable-xxhdpi/ic_step_over.png delete mode 100644 packages/react-native/ReactAndroid/src/main/res/devsupport/drawable-xxxhdpi/ic_step_over.png create mode 100644 packages/react-native/ReactAndroid/src/main/res/devsupport/drawable/paused_in_debugger_background.xml diff --git a/packages/react-native/ReactAndroid/api/ReactAndroid.api b/packages/react-native/ReactAndroid/api/ReactAndroid.api index 8cf7943de73..aadda62ceda 100644 --- a/packages/react-native/ReactAndroid/api/ReactAndroid.api +++ b/packages/react-native/ReactAndroid/api/ReactAndroid.api @@ -1175,7 +1175,6 @@ public class com/facebook/react/bridge/ReactInstanceManagerInspectorTarget : jav public fun (Lcom/facebook/react/bridge/ReactInstanceManagerInspectorTarget$TargetDelegate;)V public fun close ()V public fun sendDebuggerResumeCommand ()V - public fun sendDebuggerStepOverCommand ()V } public abstract interface class com/facebook/react/bridge/ReactInstanceManagerInspectorTarget$TargetDelegate { @@ -2443,7 +2442,6 @@ public abstract interface class com/facebook/react/devsupport/interfaces/DevSupp public abstract interface class com/facebook/react/devsupport/interfaces/DevSupportManager$PausedInDebuggerOverlayCommandListener { public abstract fun onResume ()V - public abstract fun onStepOver ()V } public abstract interface class com/facebook/react/devsupport/interfaces/ErrorCustomizer { diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java index c85a737b73d..c12e171c69a 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java @@ -1516,14 +1516,6 @@ public class ReactInstanceManager { mInspectorTarget.sendDebuggerResumeCommand(); } } - - @Override - public void onStepOver() { - UiThreadUtil.assertOnUiThread(); - if (mInspectorTarget != null) { - mInspectorTarget.sendDebuggerStepOverCommand(); - } - } }); } } diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactInstanceManagerInspectorTarget.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactInstanceManagerInspectorTarget.java index a0395cdb959..f99291dabad 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactInstanceManagerInspectorTarget.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactInstanceManagerInspectorTarget.java @@ -42,8 +42,6 @@ public class ReactInstanceManagerInspectorTarget implements AutoCloseable { public native void sendDebuggerResumeCommand(); - public native void sendDebuggerStepOverCommand(); - public void close() { mHybridData.resetNative(); } diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerBase.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerBase.java index 897c4ed8651..a877ec1c30a 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerBase.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerBase.java @@ -1191,12 +1191,10 @@ public abstract class DevSupportManagerBase implements DevSupportManager { pausedText.setText(message); View resumeButton = Assertions.assertNotNull(dialogView.findViewById(R.id.resume_button)); resumeButton.setOnClickListener((v) -> listener.onResume()); - View stepOverButton = - Assertions.assertNotNull(dialogView.findViewById(R.id.step_over_button)); - stepOverButton.setOnClickListener((v) -> listener.onStepOver()); Window dialogWindow = mPausedInDebuggerDialog.getWindow(); if (dialogWindow != null) { dialogWindow.setGravity(Gravity.TOP); + dialogWindow.setBackgroundDrawableResource(R.drawable.paused_in_debugger_background); } mPausedInDebuggerDialog.show(); }); diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/interfaces/DevSupportManager.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/interfaces/DevSupportManager.kt index 2353d65ab19..c16751534e9 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/interfaces/DevSupportManager.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/interfaces/DevSupportManager.kt @@ -125,7 +125,5 @@ public interface DevSupportManager : JSExceptionHandler { public interface PausedInDebuggerOverlayCommandListener { public fun onResume() - - public fun onStepOver() } } diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactHostImpl.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactHostImpl.java index f2caeff7bd8..1ac87ed7deb 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactHostImpl.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactHostImpl.java @@ -483,14 +483,6 @@ public class ReactHostImpl implements ReactHost { mReactHostInspectorTarget.sendDebuggerResumeCommand(); } } - - @Override - public void onStepOver() { - UiThreadUtil.assertOnUiThread(); - if (mReactHostInspectorTarget != null) { - mReactHostInspectorTarget.sendDebuggerStepOverCommand(); - } - } }); } } diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactHostInspectorTarget.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactHostInspectorTarget.kt index 67368d673c4..c6f916155ab 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactHostInspectorTarget.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactHostInspectorTarget.kt @@ -26,8 +26,6 @@ internal class ReactHostInspectorTarget(private val reactHostImpl: ReactHostImpl public external fun sendDebuggerResumeCommand() - public external fun sendDebuggerStepOverCommand() - override fun close() { mHybridData.resetNative() } diff --git a/packages/react-native/ReactAndroid/src/main/jni/react/jni/ReactInstanceManagerInspectorTarget.cpp b/packages/react-native/ReactAndroid/src/main/jni/react/jni/ReactInstanceManagerInspectorTarget.cpp index 042e5cf934d..c97907bc63d 100644 --- a/packages/react-native/ReactAndroid/src/main/jni/react/jni/ReactInstanceManagerInspectorTarget.cpp +++ b/packages/react-native/ReactAndroid/src/main/jni/react/jni/ReactInstanceManagerInspectorTarget.cpp @@ -88,16 +88,6 @@ void ReactInstanceManagerInspectorTarget::sendDebuggerResumeCommand() { } } -void ReactInstanceManagerInspectorTarget::sendDebuggerStepOverCommand() { - if (inspectorTarget_) { - inspectorTarget_->sendCommand(HostCommand::DebuggerStepOver); - } else { - jni::throwNewJavaException( - "java/lang/IllegalStateException", - "Cannot send command while the Fusebox backend is not enabled"); - } -} - void ReactInstanceManagerInspectorTarget::registerNatives() { registerHybrid({ makeNativeMethod( @@ -105,9 +95,6 @@ void ReactInstanceManagerInspectorTarget::registerNatives() { makeNativeMethod( "sendDebuggerResumeCommand", ReactInstanceManagerInspectorTarget::sendDebuggerResumeCommand), - makeNativeMethod( - "sendDebuggerStepOverCommand", - ReactInstanceManagerInspectorTarget::sendDebuggerStepOverCommand), }); } diff --git a/packages/react-native/ReactAndroid/src/main/jni/react/jni/ReactInstanceManagerInspectorTarget.h b/packages/react-native/ReactAndroid/src/main/jni/react/jni/ReactInstanceManagerInspectorTarget.h index b9ec235d089..4aead15d30e 100644 --- a/packages/react-native/ReactAndroid/src/main/jni/react/jni/ReactInstanceManagerInspectorTarget.h +++ b/packages/react-native/ReactAndroid/src/main/jni/react/jni/ReactInstanceManagerInspectorTarget.h @@ -45,7 +45,6 @@ class ReactInstanceManagerInspectorTarget delegate); void sendDebuggerResumeCommand(); - void sendDebuggerStepOverCommand(); static void registerNatives(); diff --git a/packages/react-native/ReactAndroid/src/main/jni/react/runtime/jni/JReactHostInspectorTarget.cpp b/packages/react-native/ReactAndroid/src/main/jni/react/runtime/jni/JReactHostInspectorTarget.cpp index 0575aba4f54..dbcfa3f0a8b 100644 --- a/packages/react-native/ReactAndroid/src/main/jni/react/runtime/jni/JReactHostInspectorTarget.cpp +++ b/packages/react-native/ReactAndroid/src/main/jni/react/runtime/jni/JReactHostInspectorTarget.cpp @@ -73,25 +73,12 @@ void JReactHostInspectorTarget::sendDebuggerResumeCommand() { } } -void JReactHostInspectorTarget::sendDebuggerStepOverCommand() { - if (inspectorTarget_) { - inspectorTarget_->sendCommand(HostCommand::DebuggerStepOver); - } else { - jni::throwNewJavaException( - "java/lang/IllegalStateException", - "Cannot send command while the Fusebox backend is not enabled"); - } -} - void JReactHostInspectorTarget::registerNatives() { registerHybrid({ makeNativeMethod("initHybrid", JReactHostInspectorTarget::initHybrid), makeNativeMethod( "sendDebuggerResumeCommand", JReactHostInspectorTarget::sendDebuggerResumeCommand), - makeNativeMethod( - "sendDebuggerStepOverCommand", - JReactHostInspectorTarget::sendDebuggerStepOverCommand), }); } diff --git a/packages/react-native/ReactAndroid/src/main/jni/react/runtime/jni/JReactHostInspectorTarget.h b/packages/react-native/ReactAndroid/src/main/jni/react/runtime/jni/JReactHostInspectorTarget.h index aea5ab41732..e27655793ae 100644 --- a/packages/react-native/ReactAndroid/src/main/jni/react/runtime/jni/JReactHostInspectorTarget.h +++ b/packages/react-native/ReactAndroid/src/main/jni/react/runtime/jni/JReactHostInspectorTarget.h @@ -54,7 +54,6 @@ class JReactHostInspectorTarget static void registerNatives(); void sendDebuggerResumeCommand(); - void sendDebuggerStepOverCommand(); jsinspector_modern::HostTarget* getInspectorTarget(); diff --git a/packages/react-native/ReactAndroid/src/main/res/devsupport/drawable-hdpi/ic_step_over.png b/packages/react-native/ReactAndroid/src/main/res/devsupport/drawable-hdpi/ic_step_over.png deleted file mode 100644 index 5fd364d79d5576a7db3f6ef8da0781666e35dd74..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 764 zcmVPx%wn;=mRA@u(*G-6(WfTYS-)LkCVUdx7Nb4j>l%VKC1))V$w9zD8Qm1eVL20%Zz|7c>Qm1eVLk zOM&T_jfGf&r|~HM!7n(5Z}A)cE_dB?!FT|ei&wA?&*H)VY49Qr;4}P`;L2F402W~j zUc;>H=6W)H88a~l4{`g)Q+#%!Q|lvqfvZ&n6#&m*M`w@an1(-b1P5_8t@1!xYZ=xj znCSUj*ZfxOpDX}jn_zKeGJ6T{;w$`%n|+PNjD#8iF4PL*uHkw7SOGDN0>SEM@bjSODSV0-Q-#g>_n`H6 zJU0x0mpkdd$+Y=0)##7Lxc9l7gP*g}-WSI_Y{$bmjJJ}E2!g-Hf@Bx~A9QK*KK{e1 zF7pFKujdzFcb783bfnIq9QN1&qh~&j<4K&!XJUuMuK0MO0fc>C&m?)X&-+2hKD?cS zI@-(X%>NkXh}0$6ivSx57IgtI{(ows0eqed>ohhYEHZk+5=Zm%-ad9^j7FSp!{WY$ z7Ygp|qWHaxqVqdeBBt+nFs*k^H_Ajbj0ir zxPTjdorU+~3t!mkN)GUt*pK@r0>GFUtUlZTR2i(+HwCH;R_mJrRR*i|O@S(d)%vDD umBDI#Q=rOVwZ17(Ww2V`6sR&-t-l3xQf)DnmXqcH0000Px$aY;l$R9Hvt)W1tsQ5?tdmx_q!pbjDm27wMaWs6e|;iBLo7|jjh=Ah8fmJn!d zx#*BnQ;4GY7X*PgGz3CFAP9031rY^N&w(>Mi258gc@XZM?mhS3@8|PU9W2;c2`?>p8JQtYQNHu45$EKqHngkUCw) zHyoe~qv#0c{^A*a=9y~1002ovPDHLkV1mTPy37Co diff --git a/packages/react-native/ReactAndroid/src/main/res/devsupport/drawable-xhdpi/ic_step_over.png b/packages/react-native/ReactAndroid/src/main/res/devsupport/drawable-xhdpi/ic_step_over.png deleted file mode 100644 index 5a1b26c72a425cbf0b3db979da3aaff15d3e7afa..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 908 zcmeAS@N?(olHy`uVBq!ia0vp^4j|0I1|(Ny7TyC=jKx9jP7LeL$-HD>V0QC#aSW-5 zdppDXgm0k8@%s6DPHDg2BkU=1s-cmGqjQRoFx!+Qm8B~EJQF4|Iw`T8a1c^u(@0uj z!{#KXC{#J+$=g3SpKqRf?&rIm-`7>|_e)a89vdbQ0$f;tZa#26ZPLXIre)0S4HFyk_D|Z&uE(&N z@$cS;*EE=ZF}pWZn!0_kQp%Cuu>9EHo!d>D8a^J-OvvHtT0fB|j?urt|A0b5gh5fl{iE_AFSNtKMUGjl z`u7z{wQCPnKe`yk^5U3W#qz&Q)0ot?lsw`u@a|yo`DizvQS90a{o>i8jK5=Eckx?s z>8uxilki}s^o*o%;Rfr{Uw`v=vofxFkZ-eo)t6T+{Jaf$3}qE{D!r*}bv^#Bko97yew_Iy-tkhL)+@tUj>pJ8<=jqY>Z%-bDF_a zddG}UzQT{U_SpJ2K74okd56K@myiG13h%gck41(ptU^JJ**w_clzBlsX>H=;9-Q zD;YhQvJxK$nb|P8E%k6{zN+S+YiM>>LTgXvRu%ne*GkW-IJB?oU!C!@e}4bPe66NS zCDUGd>SmVoFFPxKvBGvy+}q>qrn4F5t_}>}{8wiA!&uAz!Y)UHFE5Y_oiwv^D?8&? zhW_qFZMwqRQjBVjzx|jPpG^@vlX#+`DRzeCoe5;}E~OvHXJ*QB4BW$Y8<@QqJYD@< J);T3K0RV9HjQ#)s diff --git a/packages/react-native/ReactAndroid/src/main/res/devsupport/drawable-xxhdpi/ic_step_over.png b/packages/react-native/ReactAndroid/src/main/res/devsupport/drawable-xxhdpi/ic_step_over.png deleted file mode 100644 index fa30e23a241fa895dab38e365c48d54ab40c748b..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 1670 zcmchY>pRm60LQoanay2MvFTYcBy-E?B+9KUv8Bu`zkaM;Fi{(o`XQ(hY9X3r;>x`i<4e1h41J+#O5A-7m?3onW+Xa zOKtOT%&$%POq}j6nU-(lOZ8XB^NbBwecp$v)&8%+bUs2v2)MXJE z2wnp_@P~dFNl%JNVtw&FCJ8m&e*!>Eu7fPF&uMVct#wL}VMVusX2_K(0Hrg9F%>>Y zQK4{pQ>1*-%FD`JZ4Yn?#A2PaPIOZP>n_8+$oWO3zi@h*_;f#kt2Ew` zrGth|8rpc!G9f+pnv1d~G#CCF&ows7x+9dXf$?+#e;pKIJ_g`{{Dz?9+6VpzBx+yG zQY9Pnb+lz(fbKxskO_jaC0Ucw>@90fwENbL`3!aBi@Q|Gst4IqgX0ds^=CR5H8_Jo%YD^l@Dm66_GLw% zyT6pS^3m4W`8kcrKDP4w42$YK78NJGrQydggENDU!P1^(Z@m?teQ0m}GVGy%nlhpT z=4Y9qmslnUjx4a8R&k}&}O%I3yrrz)*vQVFiMe2)$9^oCd4mme=Ac7>D5k}owT#4yh6V6m_74O6$*-sif zTJO`8S9{~S_w4M;e?H=i`w`0?McPfv^rLeya0s00(hehYY*^@h%)Z!z0z9K2u-aw5f=72Wd(mrcYmXt zUPi^O;+SWnD^3oxTtQtoy7-kaE2zcM*Fi0e#ux&-B|1t6z^Bg+!~A m-M_i1N|U_*L!kd^;0*{-JRRD33QONS76`$^$GyQdB=c`0>;HlP diff --git a/packages/react-native/ReactAndroid/src/main/res/devsupport/drawable-xxxhdpi/ic_step_over.png b/packages/react-native/ReactAndroid/src/main/res/devsupport/drawable-xxxhdpi/ic_step_over.png deleted file mode 100644 index f708d64dd37bc5b271df59346945fde475e791cb..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 2059 zcmdUw`6Js01IE8elQ`DU2x?Nto4A@eH#Ah+Op_*#W)g`~FH&n)ty|sZm9JIRO_|Y3 zQH;dBRx_rWDXK;0zUqit(IVw_1)*=>KVv^U&*$^o^W&4^LZcuRH5CB>Ksr!KjL+o! zKk|sr{o?GEp3i{XVo>aXI?;*u03g@tK>C&$?Y+v4SPCQ`dwK3Ji6lrBgj{#(vVqPd)FVZc5JVNT#{q%l-L>6Vtn* zonDbh6cdav^}w0q{FkSri-5vhp@JCJeFE(5+mZig3RMZ5;ADU%;1;OH(Fc>j7|6k) z^4jS&+?v&z#TtGMwkE$899EU5k>?02fRC$=qsMjJZvt|MkSXXC+zu|Y7P=2q(`+FN zh^IghJbwvT4TeH!5DDZz61J>S+2$2&-1fFK4un%Uj~=x{gwwbJ|8iGnEM#+ZRxZGG zWw8vl^3FFcCNM8I(q^n2MU0bek?qIyO4W#GxuAl3Aq;;j|0Fzn82y1?$`>UyKINcUfdEI41Th+^rU$|6{<;hBy;Yfd(hC<1yy(!Hj ztYROG)X$x0sX@_;Hl0G%xNfYl<`Ul*Am+*I)Bsq2=*o+1naO1^^WK?2RLe6=lQGgx zTcYh&UFa^z`70|nG=J9@C$tix)b98dPs5}8eOI!>t$~LMWS$MaYl!>j%=!EELsxvU z!W!Z6(xu1INu7>e;cYsC6PNSKt4B+XDr`x^Drkt3LLcT7vt-L*U+udzKzg4iT?SnPU^KkhiY-^&=c;ep067iWLm`Dw^t{`4bNgVsZ3IAn9w${ zu5!fI?ausxFi1bmt9KOd47&h`XqYv_kLTbtR6o( z5WZi9p`-+1E}4FixBb_WI{l&vc5Yk`0bL?&UB4*3@vnWX$o~N2A5Ulb>T)FSBH}#_KEMeg&OM=yIW(H0OCQp5crk)z8gFiZ68n9tMoU! zR7Uk=Y}I@A;Xj;BwKoQkadV18ieuNX4U>`5D(~QFpYN8Ir7TPO?Ln^ukAX_0LCdns z7(-R%2!v@`3+=E6M&@c?UKrWEz8ym$oGfH!y0E0YTl~zV!K_~s%n{IG@P}Qm_;|(n ziz>ezu1AE+>aH>}Dsi*=WRU# z9tL90RvQc>F|7wf$jY$#1;%Cpjj1-={AuHk|CbZr^U%bxp1ttay3>mj{q0R?bLuyh zPqnxoBLw|E7=oFs41GPLx7x(Okqac+r#zVKW@gRS)LWN8bI%&k&m_3dN_oZW<8Lt# zt9$r)AB!g~@uTf#xHwBW=w>3%yoThwxVvK?HzB8mt@X`2`vdE78coS7USOWB(2Qd1 zHl)99Cpa$lXd7|{s(Dp55XO4>fRZ5x^*eL82;fBz`X!@<^8d!)q;Z&bH=evuV8cw+ ztPF|xhnACbFmvcHsrS*kYTs$DhCnqyCvu-ccB)}UBmt5xta!8lqju(AI9&u>5Hskv mpyh8J%Cu+zF65s%vwbe9W&reCiZA~B?tlZCMyj)CC;ks)Si$@N diff --git a/packages/react-native/ReactAndroid/src/main/res/devsupport/drawable/paused_in_debugger_background.xml b/packages/react-native/ReactAndroid/src/main/res/devsupport/drawable/paused_in_debugger_background.xml new file mode 100644 index 00000000000..5b1da238fc4 --- /dev/null +++ b/packages/react-native/ReactAndroid/src/main/res/devsupport/drawable/paused_in_debugger_background.xml @@ -0,0 +1,27 @@ + + + + + + + + + + + + + diff --git a/packages/react-native/ReactAndroid/src/main/res/devsupport/layout/paused_in_debugger_view.xml b/packages/react-native/ReactAndroid/src/main/res/devsupport/layout/paused_in_debugger_view.xml index ce9ca674565..9d250308b05 100644 --- a/packages/react-native/ReactAndroid/src/main/res/devsupport/layout/paused_in_debugger_view.xml +++ b/packages/react-native/ReactAndroid/src/main/res/devsupport/layout/paused_in_debugger_view.xml @@ -5,12 +5,9 @@ android:id="@+id/layout" android:layout_width="match_parent" android:layout_height="wrap_content" - android:background="#ffffc1" - android:divider="#cacaca" android:gravity="center" android:layoutDirection="ltr" android:orientation="horizontal" - android:showDividers="middle" tools:ignore="MissingDefaultResource" > @@ -18,10 +15,10 @@ android:id="@+id/paused_text" android:layout_width="wrap_content" android:layout_height="wrap_content" - android:paddingHorizontal="12dp" + android:paddingStart="14dp" android:text="" android:textColor="@android:color/black" - android:textSize="14sp" + android:textSize="16sp" android:textStyle="bold" app:autoSizeTextType="uniform" /> @@ -36,15 +33,4 @@ android:paddingVertical="8dp" android:src="@drawable/ic_resume" /> - -