From 3371fb57b72e297f43fa07ac0a20ab157c67a6bb Mon Sep 17 00:00:00 2001 From: Tim Yung Date: Sun, 18 May 2025 08:08:24 -0700 Subject: [PATCH] RN: Migrate to ESM - ReactDevToolsSettingsManager (#51440) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/51440 Migrates files to use ESM to mitigate the existing lint warning. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D74949984 fbshipit-source-id: e89eb482835cb3a3d3b997dc766803dd307a6b99 --- .../ReactDevToolsSettingsManager.android.js | 17 ++++++------ .../ReactDevToolsSettingsManager.ios.js | 27 +++++++++---------- .../ReactDevToolsSettingsManager.js.flow | 10 +++---- 3 files changed, 23 insertions(+), 31 deletions(-) diff --git a/packages/react-native/src/private/devsupport/rndevtools/ReactDevToolsSettingsManager.android.js b/packages/react-native/src/private/devsupport/rndevtools/ReactDevToolsSettingsManager.android.js index 96d6f94b6af..bc95304aa0e 100644 --- a/packages/react-native/src/private/devsupport/rndevtools/ReactDevToolsSettingsManager.android.js +++ b/packages/react-native/src/private/devsupport/rndevtools/ReactDevToolsSettingsManager.android.js @@ -4,17 +4,16 @@ * This source code is licensed under the MIT license found in the * LICENSE file in the root directory of this source tree. * - * @flow strict-local + * @flow strict * @format */ import NativeReactDevToolsSettingsManager from './specs/NativeReactDevToolsSettingsManager'; -module.exports = { - setGlobalHookSettings(settings: string) { - NativeReactDevToolsSettingsManager?.setGlobalHookSettings(settings); - }, - getGlobalHookSettings(): ?string { - return NativeReactDevToolsSettingsManager?.getGlobalHookSettings(); - }, -}; +export function setGlobalHookSettings(settings: string) { + NativeReactDevToolsSettingsManager?.setGlobalHookSettings(settings); +} + +export function getGlobalHookSettings(): ?string { + return NativeReactDevToolsSettingsManager?.getGlobalHookSettings(); +} diff --git a/packages/react-native/src/private/devsupport/rndevtools/ReactDevToolsSettingsManager.ios.js b/packages/react-native/src/private/devsupport/rndevtools/ReactDevToolsSettingsManager.ios.js index 91ac55995c0..12b10e4c558 100644 --- a/packages/react-native/src/private/devsupport/rndevtools/ReactDevToolsSettingsManager.ios.js +++ b/packages/react-native/src/private/devsupport/rndevtools/ReactDevToolsSettingsManager.ios.js @@ -12,19 +12,16 @@ import Settings from '../../../../Libraries/Settings/Settings'; const GLOBAL_HOOK_SETTINGS = 'ReactDevTools::HookSettings'; -const ReactDevToolsSettingsManager = { - setGlobalHookSettings(settings: string): void { - Settings.set({ - [GLOBAL_HOOK_SETTINGS]: settings, - }); - }, - getGlobalHookSettings(): ?string { - const value = Settings.get(GLOBAL_HOOK_SETTINGS); - if (typeof value === 'string') { - return value; - } - return null; - }, -}; +export function setGlobalHookSettings(settings: string) { + Settings.set({ + [GLOBAL_HOOK_SETTINGS]: settings, + }); +} -module.exports = ReactDevToolsSettingsManager; +export function getGlobalHookSettings(): ?string { + const value = Settings.get(GLOBAL_HOOK_SETTINGS); + if (typeof value === 'string') { + return value; + } + return null; +} diff --git a/packages/react-native/src/private/devsupport/rndevtools/ReactDevToolsSettingsManager.js.flow b/packages/react-native/src/private/devsupport/rndevtools/ReactDevToolsSettingsManager.js.flow index f0e19aa5b53..f50b8a2df65 100644 --- a/packages/react-native/src/private/devsupport/rndevtools/ReactDevToolsSettingsManager.js.flow +++ b/packages/react-native/src/private/devsupport/rndevtools/ReactDevToolsSettingsManager.js.flow @@ -4,13 +4,9 @@ * This source code is licensed under the MIT license found in the * LICENSE file in the root directory of this source tree. * - * @flow strict-local + * @flow strict * @format */ -declare const ReactDevToolsSettingsManager: { - setGlobalHookSettings(settings: string): void, - getGlobalHookSettings(): ?string, -}; - -module.exports = ReactDevToolsSettingsManager; +declare export function setGlobalHookSettings(settings: string): void; +declare export function getGlobalHookSettings(): ?string;