From 33181ef8afd621252c7cbf181b15fc162fc294a2 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Thu, 14 Sep 2023 11:13:16 -0700 Subject: [PATCH] Deprecate ReactPackage.createNativeModules recommending using getModule instead (#39339) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/39339 Deprecating createNativeModules method from ReactPackage interface recommending using getModule instead in the new architecture of React Native changelog: [Android][Changed] Deprecating createNativeModules method from ReactPackage interface recommending using getModule instead in the new architecture of React Native Reviewed By: cortinico Differential Revision: D48992719 fbshipit-source-id: b20de9274ed4bd35a239c672b52bfac529a79bc2 --- .../src/main/java/com/facebook/react/ReactPackage.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactPackage.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactPackage.java index f09953e633e..a579354f218 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactPackage.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactPackage.java @@ -11,6 +11,7 @@ import androidx.annotation.NonNull; import com.facebook.infer.annotation.Nullsafe; import com.facebook.react.bridge.NativeModule; import com.facebook.react.bridge.ReactApplicationContext; +import com.facebook.react.common.annotations.DeprecatedInNewArchitecture; import com.facebook.react.uimanager.UIManagerModule; import com.facebook.react.uimanager.ViewManager; import java.util.List; @@ -37,9 +38,11 @@ public interface ReactPackage { /** * @param reactContext react application context that can be used to create modules - * @return list of native modules to register with the newly created catalyst instance + * @return list of native modules to register with the newly created catalyst instance This method + * is deprecated in the new Architecture of React Native. */ @NonNull + @DeprecatedInNewArchitecture List createNativeModules(@NonNull ReactApplicationContext reactContext); /** @return a list of view managers that should be registered with {@link UIManagerModule} */