From 32fafdf9807e8869a9bf927d031741b8ab6c2fb3 Mon Sep 17 00:00:00 2001 From: Jan Kassens Date: Fri, 9 May 2025 23:01:51 -0700 Subject: [PATCH] cleanup shipped flag enableFabricCompleteRootInCommitPhase Summary: Flag was removed in {D74196673}, this cleans up the dynamic flag. bypass-github-export-checks Changelog: [internal] Reviewed By: jackpope Differential Revision: D74493584 fbshipit-source-id: 6ade542b7e1bd9c4367b7dbef4d2f1ec2d79d0df --- .../runtime/mocks/ReactNativeInternalFeatureFlags.js | 4 +--- .../ReactNative/__tests__/ReactFabric-Suspense-itest.js | 2 -- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/packages/react-native-fantom/runtime/mocks/ReactNativeInternalFeatureFlags.js b/packages/react-native-fantom/runtime/mocks/ReactNativeInternalFeatureFlags.js index fea03724a18..2e00405a4db 100644 --- a/packages/react-native-fantom/runtime/mocks/ReactNativeInternalFeatureFlags.js +++ b/packages/react-native-fantom/runtime/mocks/ReactNativeInternalFeatureFlags.js @@ -9,6 +9,4 @@ * @oncall react_native */ -module.exports = { - enableFabricCompleteRootInCommitPhase: true, -}; +module.exports = {}; diff --git a/packages/react-native/Libraries/ReactNative/__tests__/ReactFabric-Suspense-itest.js b/packages/react-native/Libraries/ReactNative/__tests__/ReactFabric-Suspense-itest.js index 64485e0274a..ae833aa6032 100644 --- a/packages/react-native/Libraries/ReactNative/__tests__/ReactFabric-Suspense-itest.js +++ b/packages/react-native/Libraries/ReactNative/__tests__/ReactFabric-Suspense-itest.js @@ -186,8 +186,6 @@ describe('Suspense', () => { expect(resolveFunction).toBeNull(); }); - // TODO(T207868872): this test only succeeds with enableFabricCompleteRootInCommitPhase enabled. - // enableFabricCompleteRootInCommitPhase is hardcoded to true in the testing environment. it('shows stale data while transition is happening', () => { cache.clear(); cache.set(SquareId.Green, {color: 'green'});