From 31eb235a6add02836753a9f598900a7e1c412452 Mon Sep 17 00:00:00 2001 From: Luna Wei Date: Wed, 14 Jun 2023 07:44:51 -0700 Subject: [PATCH] Fix set-rn-version (#37854) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/37854 Changelog: [Internal] - Fix `saveFiles` in set-rn-version, incorrect function invoke Reviewed By: NickGerleman Differential Revision: D46582168 fbshipit-source-id: 944e182a88a1aa79bbf47d36ef8395c21dfefb24 --- scripts/__tests__/set-rn-version-test.js | 1 - scripts/set-rn-version.js | 9 +++++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/scripts/__tests__/set-rn-version-test.js b/scripts/__tests__/set-rn-version-test.js index 5c83cb002ee..019aef2a62d 100644 --- a/scripts/__tests__/set-rn-version-test.js +++ b/scripts/__tests__/set-rn-version-test.js @@ -156,7 +156,6 @@ describe('set-rn-version', () => { sedMock.mockReturnValueOnce({code: 0}); const filesToValidate = [ 'packages/react-native/package.json', - 'packages/react-native/ReactAndroid/gradle.properties', 'packages/react-native/template/package.json', ]; diff --git a/scripts/set-rn-version.js b/scripts/set-rn-version.js index 4081ee42afb..189e882fb13 100755 --- a/scripts/set-rn-version.js +++ b/scripts/set-rn-version.js @@ -155,14 +155,19 @@ function setReactNativeVersion(argVersion, dependencyVersions, buildType) { // Create tmp folder for copies of files to verify files have changed const filesToValidate = [ 'packages/react-native/package.json', - 'packages/react-native/ReactAndroid/gradle.properties', 'packages/react-native/template/package.json', ]; const tmpVersioningFolder = fs.mkdtempSync( path.join(os.tmpdir(), 'rn-set-version'), ); echo(`The tmp versioning folder is ${tmpVersioningFolder}`); - saveFiles(tmpVersioningFolder); + saveFiles( + [ + 'packages/react-native/package.json', + 'packages/react-native/template/package.json', + ], + tmpVersioningFolder, + ); setSource(version); setPackage(version, dependencyVersions);